From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5497AC4338F for ; Tue, 3 Aug 2021 05:37:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 334B760EBD for ; Tue, 3 Aug 2021 05:37:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233758AbhHCFhN (ORCPT ); Tue, 3 Aug 2021 01:37:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:43822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231386AbhHCFhL (ORCPT ); Tue, 3 Aug 2021 01:37:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 21B9A60F48; Tue, 3 Aug 2021 05:36:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627969019; bh=8wr/7dE+jSZj26tooPGUxgremTinWJ9CqompU9Ny1r8=; h=Date:From:To:Subject:References:In-Reply-To:From; b=ThUNxGjvxhkUYpVm+CdfK0Qo7NIZKusVv+LWhWZre4g554VEIBq0rvNwxKc6I5klw mQFBfuRn/ITMNx0MQgZCWbJEs73GBqGdes+VzVptG3dNISn6DdseWX34SzTD57kSOU bMqDkT7HA/I+ObUjoj/KiHhkFO+2q7rH2NI+hqwU= Date: Tue, 3 Aug 2021 07:36:57 +0200 From: Greg KH To: Pavel Skripkin , davem@davemloft.net, kuba@kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+02c9f70f3afae308464a@syzkaller.appspotmail.com Subject: Re: [PATCH] net: pegasus: fix uninit-value in get_interrupt_interval Message-ID: References: <20210730214411.1973-1-paskripkin@gmail.com> <20210801223513.06bede26@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 02, 2021 at 11:07:23PM +0300, Petko Manolov wrote: > diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c > index 9a907182569c..eafbe8107907 100644 > --- a/drivers/net/usb/pegasus.c > +++ b/drivers/net/usb/pegasus.c > @@ -26,6 +26,8 @@ > * ... > * v0.9.3 simplified [get|set]_register(s), async update registers > * logic revisited, receive skb_pool removed. > + * v1.0.1 add error checking for set_register(s)(), see if calling > + * get_registers() has failed and print a message accordingly. > */ > > #include > @@ -45,7 +47,7 @@ > /* > * Version Information > */ > -#define DRIVER_VERSION "v0.9.3 (2013/04/25)" > +#define DRIVER_VERSION "v1.0.1 (2021/08/01)" Nit, the log above, and the driver version here, mean nothing when it comes to code in the kernel tree, both should be dropped as we have full kernel changelog through git, and the version is bound to the kernel release the driver came in. thanks, greg k-h