From: Leon Romanovsky <firstname.lastname@example.org>
To: Jakub Kicinski <email@example.com>
Cc: "David S . Miller" <firstname.lastname@example.org>,
Subject: Re: [PATCH net-next v1] netdevsim: Forbid devlink reload when adding or deleting ports
Date: Thu, 5 Aug 2021 21:02:23 +0300 [thread overview]
Message-ID: <YQwnr/qel0oktItP@unreal> (raw)
On Thu, Aug 05, 2021 at 08:35:59PM +0300, Leon Romanovsky wrote:
> On Thu, Aug 05, 2021 at 08:27:56AM -0700, Jakub Kicinski wrote:
> > On Thu, 5 Aug 2021 17:33:35 +0300 Leon Romanovsky wrote:
> > > On Thu, Aug 05, 2021 at 07:23:42AM -0700, Jakub Kicinski wrote:
> > > > > This is what devlink_reload_disable() returns, so I kept same error.
> > > > > It is not important at all.
> > > > >
> > > > > What about the following change on top of this patch?
> > > >
> > > > LGTM, the only question is whether we should leave in_reload true
> > > > if nsim_dev->fail_reload is set.
> > >
> > > I don't think so, it will block add/delete ports.
> > As it should, given add/delete ports takes the port_list_lock which is
> > destroyed by down but not (due to the forced failure) re-initialized by
> > up.
> > If we want to handle adding ports while down we can just bump port
> > count and return, although I don't think there's a practical need
> > to support that.
> Sorry, but for me netdevsim looks like complete dumpster. It was
> intended for fast prototyping, but ended to be huge pile of debugfs
> entries and selftest to execute random flows.
> Do you want me to move in_reload = false line to be after if (nsim_dev->fail_reload)
BTW, the current implementation where in_reload before if, actually
preserves same behaviour as was with devlink_reload_enable() implementation.
next prev parent reply other threads:[~2021-08-05 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 11:02 [PATCH net-next] netdevsim: Forbid devlink reload when adding or deleting ports Leon Romanovsky
2021-08-05 11:05 ` [PATCH net-next v1] " Leon Romanovsky
2021-08-05 12:40 ` [PATCH net-next] " patchwork-bot+netdevbpf
2021-08-05 13:15 ` [PATCH net-next v1] " Jakub Kicinski
2021-08-05 13:51 ` Leon Romanovsky
2021-08-05 14:23 ` Jakub Kicinski
2021-08-05 14:33 ` Leon Romanovsky
2021-08-05 15:27 ` Jakub Kicinski
2021-08-05 17:35 ` Leon Romanovsky
2021-08-05 18:02 ` Leon Romanovsky [this message]
2021-08-05 19:12 ` Jakub Kicinski
2021-08-06 11:19 ` Leon Romanovsky
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).