From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B707C432BE for ; Tue, 17 Aug 2021 09:05:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FE6960FA0 for ; Tue, 17 Aug 2021 09:05:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239136AbhHQJGC (ORCPT ); Tue, 17 Aug 2021 05:06:02 -0400 Received: from mga01.intel.com ([192.55.52.88]:47808 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235373AbhHQJGA (ORCPT ); Tue, 17 Aug 2021 05:06:00 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10078"; a="238106986" X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="238106986" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 02:05:23 -0700 X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="471089536" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 02:05:20 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mFv22-00Agg5-H2; Tue, 17 Aug 2021 12:05:14 +0300 Date: Tue, 17 Aug 2021 12:05:14 +0300 From: Andy Shevchenko To: Linus Walleij Cc: David Thompson , linux-kernel , "open list:GPIO SUBSYSTEM" , netdev , ACPI Devel Maling List , Bartosz Golaszewski , "David S. Miller" , Jakub Kicinski , "Rafael J. Wysocki" , Asmaa Mnebhi , Liming Sun Subject: Re: [PATCH v1 6/6] TODO: net: mellanox: mlxbf_gige: Replace non-standard interrupt handling Message-ID: References: <20210816115953.72533-1-andriy.shevchenko@linux.intel.com> <20210816115953.72533-7-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 17, 2021 at 01:06:06AM +0200, Linus Walleij wrote: > On Mon, Aug 16, 2021 at 2:00 PM Andy Shevchenko > wrote: > > > Since GPIO driver supports interrupt handling, replace custom routine with > > simple IRQ request. > > > > Signed-off-by: Andy Shevchenko > > --- > > .../mellanox/mlxbf_gige/mlxbf_gige_gpio.c | 212 ------------------ > > Don't you also need to remove this file from Makefile? Of course, this is simply to show the intention. It's just a hint, I have no time to write the code for Mellanox, really :-) -- With Best Regards, Andy Shevchenko