From: Brian Norris <briannorris@chromium.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Jonas Dreßler" <verdre@v0yd.nl>,
"Amitkumar Karwar" <amitkarwar@gmail.com>,
"Ganapathi Bhat" <ganapathi017@gmail.com>,
"Xinming Hu" <huxinming820@gmail.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Tsuchiya Yuto" <kitakar@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"<netdev@vger.kernel.org>" <netdev@vger.kernel.org>,
"Linux Kernel" <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
"Maximilian Luz" <luzmaximilian@gmail.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH 1/2] mwifiex: Use non-posted PCI register writes
Date: Wed, 1 Sep 2021 14:07:43 -0700 [thread overview]
Message-ID: <YS/rn8b0O3FPBbtm@google.com> (raw)
In-Reply-To: <CA+ASDXNGR2=sQ+w1LkMiY_UCfaYgQ5tcu2pbBn46R2asv83sSQ@mail.gmail.com>
Apologies for the brain-dead mailer. I forget that I should only reply
via web when I _want_ text wrapping:
On Wed, Sep 01, 2021 at 02:04:04PM -0700, Brian Norris wrote:
> (b) latency spikes to ~6ms:
> # trace-cmd record -p function_graph -O funcgraph-abstime -l
> mwifiex_pm_wakeup_card
> # trace-cmd report
> kworker/u13:0-199 [003] 348.987306: funcgraph_entry: #
> 6219.500 us | mwifiex_pm_wakeup_card();
> kworker/u13:0-199 [003] 349.316312: funcgraph_entry: #
> 6267.625 us | mwifiex_pm_wakeup_card();
> kworker/u13:3-4057 [001] 352.238530: funcgraph_entry: #
> 6184.250 us | mwifiex_pm_wakeup_card();
> kworker/u13:0-199 [002] 356.626366: funcgraph_entry: #
> 6553.166 us | mwifiex_pm_wakeup_card();
> kworker/u13:3-4057 [002] 356.709389: funcgraph_entry: #
> 6212.500 us | mwifiex_pm_wakeup_card();
> kworker/u13:3-4057 [002] 356.847215: funcgraph_entry: #
> 6230.292 us | mwifiex_pm_wakeup_card();
> kworker/u13:3-4057 [000] 356.897576: funcgraph_entry: #
> 6451.667 us | mwifiex_pm_wakeup_card();
> kworker/u13:0-199 [004] 357.175025: funcgraph_entry: #
> 6204.042 us | mwifiex_pm_wakeup_card();
>
> whereas it used to look more like:
>
> kworker/u13:1-173 [005] 212.230542: funcgraph_entry:
> 7.000 us | mwifiex_pm_wakeup_card();
> kworker/u13:3-1768 [005] 213.886063: funcgraph_entry:
> 9.334 us | mwifiex_pm_wakeup_card();
> kworker/u13:3-1768 [002] 214.473273: funcgraph_entry: +
> 11.375 us | mwifiex_pm_wakeup_card();
> kworker/u13:3-1768 [005] 214.530705: funcgraph_entry:
> 5.542 us | mwifiex_pm_wakeup_card();
> kworker/u13:1-173 [002] 215.050168: funcgraph_entry: +
> 13.125 us | mwifiex_pm_wakeup_card();
> kworker/u13:1-173 [002] 215.106492: funcgraph_entry: +
> 11.959 us | mwifiex_pm_wakeup_card();
> kworker/u13:3-1768 [005] 215.484807: funcgraph_entry:
> 8.459 us | mwifiex_pm_wakeup_card();
> kworker/u13:1-173 [003] 215.515238: funcgraph_entry: +
> 15.166 us | mwifiex_pm_wakeup_card();
> kworker/u13:3-1768 [001] 217.175691: funcgraph_entry: +
> 11.083 us | mwifiex_pm_wakeup_card();
That should read:
# trace-cmd record -p function_graph -O funcgraph-abstime -l mwifiex_pm_wakeup_card
# trace-cmd report
kworker/u13:0-199 [003] 348.987306: funcgraph_entry: # 6219.500 us | mwifiex_pm_wakeup_card();
kworker/u13:0-199 [003] 349.316312: funcgraph_entry: # 6267.625 us | mwifiex_pm_wakeup_card();
kworker/u13:3-4057 [001] 352.238530: funcgraph_entry: # 6184.250 us | mwifiex_pm_wakeup_card();
kworker/u13:0-199 [002] 356.626366: funcgraph_entry: # 6553.166 us | mwifiex_pm_wakeup_card();
kworker/u13:3-4057 [002] 356.709389: funcgraph_entry: # 6212.500 us | mwifiex_pm_wakeup_card();
kworker/u13:3-4057 [002] 356.847215: funcgraph_entry: # 6230.292 us | mwifiex_pm_wakeup_card();
kworker/u13:3-4057 [000] 356.897576: funcgraph_entry: # 6451.667 us | mwifiex_pm_wakeup_card();
kworker/u13:0-199 [004] 357.175025: funcgraph_entry: # 6204.042 us | mwifiex_pm_wakeup_card();
vs.
kworker/u13:1-173 [005] 212.230542: funcgraph_entry: 7.000 us | mwifiex_pm_wakeup_card();
kworker/u13:3-1768 [005] 213.886063: funcgraph_entry: 9.334 us | mwifiex_pm_wakeup_card();
kworker/u13:3-1768 [002] 214.473273: funcgraph_entry: + 11.375 us | mwifiex_pm_wakeup_card();
kworker/u13:3-1768 [005] 214.530705: funcgraph_entry: 5.542 us | mwifiex_pm_wakeup_card();
kworker/u13:1-173 [002] 215.050168: funcgraph_entry: + 13.125 us | mwifiex_pm_wakeup_card();
kworker/u13:1-173 [002] 215.106492: funcgraph_entry: + 11.959 us | mwifiex_pm_wakeup_card();
kworker/u13:3-1768 [005] 215.484807: funcgraph_entry: 8.459 us | mwifiex_pm_wakeup_card();
kworker/u13:1-173 [003] 215.515238: funcgraph_entry: + 15.166 us | mwifiex_pm_wakeup_card();
kworker/u13:3-1768 [001] 217.175691: funcgraph_entry: + 11.083 us | mwifiex_pm_wakeup_card();
Brian
next prev parent reply other threads:[~2021-09-01 21:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 12:37 [PATCH 0/2] mwifiex: Work around firmware bugs on 88W8897 chip Jonas Dreßler
2021-08-30 12:37 ` [PATCH 1/2] mwifiex: Use non-posted PCI register writes Jonas Dreßler
2021-08-30 12:49 ` Andy Shevchenko
2021-09-01 14:01 ` Jonas Dreßler
2021-09-01 15:47 ` Andy Shevchenko
2021-09-01 15:51 ` Pali Rohár
2021-09-01 16:51 ` Heiner Kallweit
2021-09-01 17:07 ` Johannes Berg
2021-09-01 19:07 ` Heiner Kallweit
2021-09-01 22:41 ` Bjorn Helgaas
2021-09-02 14:05 ` Bjorn Helgaas
2021-09-01 19:40 ` Brian Norris
2021-09-01 20:40 ` Andy Shevchenko
2021-09-01 21:04 ` Brian Norris
2021-09-01 21:07 ` Brian Norris [this message]
2021-09-18 7:37 ` Jonas Dreßler
2021-09-20 17:48 ` Brian Norris
2021-09-22 12:50 ` Jonas Dreßler
2021-09-23 15:28 ` Jonas Dreßler
2021-09-23 19:37 ` Andy Shevchenko
2021-09-23 19:41 ` Andy Shevchenko
2021-09-23 20:22 ` Pali Rohár
2021-09-30 15:38 ` Jonas Dreßler
2021-09-30 15:42 ` Pali Rohár
2021-09-30 16:14 ` Jonas Dreßler
2021-09-30 16:19 ` Pali Rohár
2021-09-30 16:22 ` Jonas Dreßler
2021-09-30 16:39 ` Pali Rohár
2021-08-30 12:37 ` [PATCH 2/2] mwifiex: Try waking the firmware until we get an interrupt Jonas Dreßler
2021-08-30 12:51 ` Andy Shevchenko
2021-08-30 12:55 ` Andy Shevchenko
2021-09-25 17:32 ` [PATCH 0/2] mwifiex: Work around firmware bugs on 88W8897 chip Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS/rn8b0O3FPBbtm@google.com \
--to=briannorris@chromium.org \
--cc=amitkarwar@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=ganapathi017@gmail.com \
--cc=huxinming820@gmail.com \
--cc=kitakar@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=verdre@v0yd.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).