From: Andrew Lunn <andrew@lunn.ch>
To: Yanfei Xu <yanfei.xu@windriver.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
kuba@kernel.org, p.zabel@pengutronix.de,
syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: mdiobus: Fix memory leak in __mdiobus_register
Date: Sun, 26 Sep 2021 17:34:40 +0200 [thread overview]
Message-ID: <YVCTEBR/YolkQQyZ@lunn.ch> (raw)
In-Reply-To: <20210926045313.2267655-1-yanfei.xu@windriver.com>
On Sun, Sep 26, 2021 at 12:53:13PM +0800, Yanfei Xu wrote:
> Once device_register() failed, we should call put_device() to
> decrement reference count for cleanup. Or it will cause memory
> leak.
>
> BUG: memory leak
> unreferenced object 0xffff888114032e00 (size 256):
> comm "kworker/1:3", pid 2960, jiffies 4294943572 (age 15.920s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 08 2e 03 14 81 88 ff ff ................
> 08 2e 03 14 81 88 ff ff 90 76 65 82 ff ff ff ff .........ve.....
> backtrace:
> [<ffffffff8265cfab>] kmalloc include/linux/slab.h:591 [inline]
> [<ffffffff8265cfab>] kzalloc include/linux/slab.h:721 [inline]
> [<ffffffff8265cfab>] device_private_init drivers/base/core.c:3203 [inline]
> [<ffffffff8265cfab>] device_add+0x89b/0xdf0 drivers/base/core.c:3253
> [<ffffffff828dd643>] __mdiobus_register+0xc3/0x450 drivers/net/phy/mdio_bus.c:537
> [<ffffffff828cb835>] __devm_mdiobus_register+0x75/0xf0 drivers/net/phy/mdio_devres.c:87
> [<ffffffff82b92a00>] ax88772_init_mdio drivers/net/usb/asix_devices.c:676 [inline]
> [<ffffffff82b92a00>] ax88772_bind+0x330/0x480 drivers/net/usb/asix_devices.c:786
> [<ffffffff82baa33f>] usbnet_probe+0x3ff/0xdf0 drivers/net/usb/usbnet.c:1745
> [<ffffffff82c36e17>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
> [<ffffffff82661d17>] call_driver_probe drivers/base/dd.c:517 [inline]
> [<ffffffff82661d17>] really_probe.part.0+0xe7/0x380 drivers/base/dd.c:596
> [<ffffffff826620bc>] really_probe drivers/base/dd.c:558 [inline]
> [<ffffffff826620bc>] __driver_probe_device+0x10c/0x1e0 drivers/base/dd.c:751
> [<ffffffff826621ba>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:781
> [<ffffffff82662a26>] __device_attach_driver+0xf6/0x140 drivers/base/dd.c:898
> [<ffffffff8265eca7>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:427
> [<ffffffff826625a2>] __device_attach+0x122/0x260 drivers/base/dd.c:969
> [<ffffffff82660916>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:487
> [<ffffffff8265cd0b>] device_add+0x5fb/0xdf0 drivers/base/core.c:3359
> [<ffffffff82c343b9>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2170
> [<ffffffff82c4473c>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
>
> BUG: memory leak
> unreferenced object 0xffff888116f06900 (size 32):
> comm "kworker/0:2", pid 2670, jiffies 4294944448 (age 7.160s)
> hex dump (first 32 bytes):
> 75 73 62 2d 30 30 31 3a 30 30 33 00 00 00 00 00 usb-001:003.....
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<ffffffff81484516>] kstrdup+0x36/0x70 mm/util.c:60
> [<ffffffff814845a3>] kstrdup_const+0x53/0x80 mm/util.c:83
> [<ffffffff82296ba2>] kvasprintf_const+0xc2/0x110 lib/kasprintf.c:48
> [<ffffffff82358d4b>] kobject_set_name_vargs+0x3b/0xe0 lib/kobject.c:289
> [<ffffffff826575f3>] dev_set_name+0x63/0x90 drivers/base/core.c:3147
> [<ffffffff828dd63b>] __mdiobus_register+0xbb/0x450 drivers/net/phy/mdio_bus.c:535
> [<ffffffff828cb835>] __devm_mdiobus_register+0x75/0xf0 drivers/net/phy/mdio_devres.c:87
> [<ffffffff82b92a00>] ax88772_init_mdio drivers/net/usb/asix_devices.c:676 [inline]
> [<ffffffff82b92a00>] ax88772_bind+0x330/0x480 drivers/net/usb/asix_devices.c:786
> [<ffffffff82baa33f>] usbnet_probe+0x3ff/0xdf0 drivers/net/usb/usbnet.c:1745
> [<ffffffff82c36e17>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
> [<ffffffff82661d17>] call_driver_probe drivers/base/dd.c:517 [inline]
> [<ffffffff82661d17>] really_probe.part.0+0xe7/0x380 drivers/base/dd.c:596
> [<ffffffff826620bc>] really_probe drivers/base/dd.c:558 [inline]
> [<ffffffff826620bc>] __driver_probe_device+0x10c/0x1e0 drivers/base/dd.c:751
> [<ffffffff826621ba>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:781
> [<ffffffff82662a26>] __device_attach_driver+0xf6/0x140 drivers/base/dd.c:898
> [<ffffffff8265eca7>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:427
> [<ffffffff826625a2>] __device_attach+0x122/0x260 drivers/base/dd.c:969
>
> Reported-by: syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com
> Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-09-26 15:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 4:53 [PATCH] net: mdiobus: Fix memory leak in __mdiobus_register Yanfei Xu
2021-09-26 15:34 ` Andrew Lunn [this message]
2021-09-27 12:30 ` patchwork-bot+netdevbpf
2021-09-28 8:55 ` Dan Carpenter
2021-09-28 9:26 ` Dan Carpenter
2021-09-28 9:45 ` Pavel Skripkin
2021-09-28 10:39 ` Dan Carpenter
2021-09-28 10:46 ` Pavel Skripkin
2021-09-28 10:55 ` Dan Carpenter
2021-09-28 11:04 ` Pavel Skripkin
2021-09-28 10:59 ` Dan Carpenter
2021-09-28 11:06 ` Pavel Skripkin
2021-09-28 11:09 ` Pavel Skripkin
2021-09-28 11:30 ` Dan Carpenter
2021-09-28 11:45 ` Pavel Skripkin
2021-09-28 12:23 ` Dan Carpenter
2021-09-28 12:58 ` Russell King (Oracle)
2021-09-28 13:52 ` Dan Carpenter
2021-09-28 15:41 ` Russell King (Oracle)
2021-09-28 15:48 ` Dongliang Mu
2021-09-29 2:05 ` Xu, Yanfei
2021-09-28 13:11 ` Russell King (Oracle)
2021-09-29 21:31 ` Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVCTEBR/YolkQQyZ@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com \
--cc=yanfei.xu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).