From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Sean Anderson <sean.anderson@seco.com>
Cc: Antoine Tenart <atenart@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: Re: [PATCH v2 1/2] net: macb: Clean up macb_validate
Date: Fri, 15 Oct 2021 00:08:27 +0100 [thread overview]
Message-ID: <YWi4a5Jme5IDSuKE@shell.armlinux.org.uk> (raw)
In-Reply-To: <82025310-10f3-28fd-1b52-2b3969d5f00b@seco.com>
On Thu, Oct 14, 2021 at 01:50:36PM -0400, Sean Anderson wrote:
> On 10/14/21 12:34 PM, Russell King (Oracle) wrote:
> > You can find some patches that add the "supported_interfaces" masks
> > in git.armlinux.org.uk/linux-arm.git net-queue
> >
> > and we could add to phylink_validate():
> >
> > if (!phy_interface_empty(pl->config->supported_interfaces) &&
> > !test_bit(state->interface, pl->config->supported_interfaces))
> > return -EINVAL;
> >
> > which should go a long way to simplifying a lot of these validation
> > implementations.
> >
> > Any thoughts on that?
>
> IMO the actual issue here is PHY_INTERFACE_MODE_NA. Supporting this
> tends to add complexity to validate(), because we have a lot of code
> like
>
> if (state->interface == PHY_INTERFACE_MODE_FOO) {
> if (we_support_foo())
> phylink_set(mask, Foo);
> else if (state->interface != PHY_INTERFACE_MODE_NA) {
> linkmode_zero(supported);
> return;
> }
> }
>
> which gets even worse when we want to have different interfaces share
> logic.
There is always the option to use different operations structs if the
properties of the interfaces can be divided up in that way - and that
will probably be more efficient (not that the validate callback is a
performance critical path though.)
> IMO validate() could be much cleaner if we never called it with
> NA and instead did something like
>
> if (state->interface == PHY_INTERFACE_MODE_NA) {
> unsigned long *original;
>
> linkmode_copy(original, supported);
> for (i = 0; i < PHY_INTERFACE_MODE_MAX; i++) {
> if (test_bit(i, pl->config->supported_interfaces)) {
> unsigned long *iface_mode;
>
> linkmode_copy(iface_mode, original);
> state->interface = i;
> pl->mac_ops->validate(pl->config, iface_mode, state);
> linkmode_or(supported, supported, iface_mode);
> }
> }
> state->interface = PHY_INTERFACE_MODE_NA;
> }
>
> This of course can be done in addition to/instead of your above
> suggestion. I suggested something like this in v3 of this series, but it
> would be even better to do this on the phylink level.
In addition I think - I think we should use a non-empty
supported_interfaces as an indicator that we use the above, otherwise
we have to loop through all possible interface modes. That also
provides some encouragement to fill out the supported_interfaces
member.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-10-14 23:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 16:55 [PATCH v2 1/2] net: macb: Clean up macb_validate Sean Anderson
2021-10-11 16:55 ` [PATCH v2 2/2] net: macb: Allow SGMII only if we are a GEM in mac_validate Sean Anderson
2021-10-12 0:17 ` Jakub Kicinski
2021-10-12 8:27 ` Antoine Tenart
2021-10-12 16:20 ` Sean Anderson
2021-10-12 8:33 ` [PATCH v2 1/2] net: macb: Clean up macb_validate Antoine Tenart
2021-10-12 8:34 ` Antoine Tenart
2021-10-12 9:24 ` Nicolas Ferre
2021-10-12 16:34 ` Sean Anderson
2021-10-12 16:53 ` Antoine Tenart
2021-10-14 16:34 ` Russell King (Oracle)
2021-10-14 17:50 ` Sean Anderson
2021-10-14 23:08 ` Russell King (Oracle) [this message]
2021-10-15 22:28 ` Sean Anderson
2021-10-15 22:47 ` Russell King (Oracle)
2021-10-19 15:02 ` Russell King (Oracle)
2021-10-22 17:37 ` Sean Anderson
2021-10-25 10:35 ` Russell King (Oracle)
2021-10-25 15:26 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWi4a5Jme5IDSuKE@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=atenart@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=sean.anderson@seco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).