From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D51CEC433FE for ; Wed, 19 Jan 2022 19:19:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239621AbiASTSa (ORCPT ); Wed, 19 Jan 2022 14:18:30 -0500 Received: from mga01.intel.com ([192.55.52.88]:38080 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbiASTS1 (ORCPT ); Wed, 19 Jan 2022 14:18:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642619906; x=1674155906; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=zlzvt2tofvnyzs6MO7mvQPsbaGbCXyngZOE6fETrI9A=; b=jAA0eUdJ2LIrYzRKlLUNuqbIEXZQ58QHs42RuYwZZHobRIia1r4dtoes aEyZ/j1WZPaDU8cQlTzfRUaon6w0vJ3TezEJ11da6zlxu6tvEfzXUoTq5 R0meXV8NOWY8dfEzDBb2+TXswnx8BNUdOJEdyG9IO+hM91Wd4B8DNpEBh dxzrbZFFrZi5mrLmR8f1IuoxhYb9FK5zlF2UaC0CNcvwZxta4cRaBZf9B jp4YmdWs2YG1GzVZr7sbonMZOUg5xbnj+If+oNNnbTp/gwl8HlALyj+Et RbwYCy7F0PJrOzZ8Kvg92QlxVDVY9PO94sTCTlxST29tb2VumCDK7pCHM Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="269556994" X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="269556994" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:53:58 -0800 X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="672273896" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:53:41 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nAG4L-00CE4x-6e; Wed, 19 Jan 2022 20:52:29 +0200 Date: Wed, 19 Jan 2022 20:52:28 +0200 From: Andy Shevchenko To: Sergey Shtylyov Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mark Brown , Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , KVM list , "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , ALSA Development Mailing List , Jaroslav Kysela , Guenter Roeck , Thierry Reding , MTD Maling List , Linux I2C , Miquel Raynal , linux-phy@lists.infradead.org, Jiri Slaby , openipmi-developer@lists.sourceforge.net, "David S. Miller" , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Lee Jones , Bartosz Golaszewski , Daniel Lezcano , Kishon Vijay Abraham I , Geert Uytterhoeven , "open list:SERIAL DRIVERS" , Yoshihiro Shimoda , bcm-kernel-feedback-list , Zhang Rui , Linux PWM List , Robert Richter , Saravanan Sekar , Corey Minyard , Linux PM list , Liam Girdwood , Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , Hans de Goede , Alex Williamson , Tony Luck , Borislav Petkov , Sebastian Reichel , Jakub Kicinski , Matthias Brugger , Takashi Iwai , platform-driver-x86@vger.kernel.org, Benson Leung , Linux ARM , linux-edac@vger.kernel.org, Mun Yew Tham , Eric Auger , Greg Kroah-Hartman , "open list:GPIO SUBSYSTEM" , Cornelia Huck , Linux MMC List , Linux Kernel Mailing List , linux-spi , Linux-Renesas , Vinod Koul , James Morse , Zha Qipeng , Pengutronix Kernel Team , Richard Weinberger , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , netdev@vger.kernel.org Subject: Re: [PATCH] driver core: platform: Rename platform_get_irq_optional() to platform_get_irq_silent() Message-ID: References: <20220112085009.dbasceh3obfok5dc@pengutronix.de> <20220112213121.5ruae5mxwj6t3qiy@pengutronix.de> <20220113110831.wvwbm75hbfysbn2d@pengutronix.de> <20220113194358.xnnbhsoyetihterb@pengutronix.de> <386a7f56-38c8-229c-4fec-4b38a77c4121@omp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <386a7f56-38c8-229c-4fec-4b38a77c4121@omp.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jan 14, 2022 at 10:45:38PM +0300, Sergey Shtylyov wrote: > On 1/13/22 10:43 PM, Uwe Kleine-König wrote: > > > The subsystems regulator, clk and gpio have the concept of a dummy > > resource. For regulator, clk and gpio there is a semantic difference > > between the regular _get() function and the _get_optional() variant. > > (One might return the dummy resource, the other won't. Unfortunately > > which one implements which isn't the same for these three.) The > > difference between platform_get_irq() and platform_get_irq_optional() is > > only that the former might emit an error message and the later won't. > > > > To prevent people's expectations that there is a semantic difference > > between these too, rename platform_get_irq_optional() to > > platform_get_irq_silent() to make the actual difference more obvious. > > > > The #define for the old name can and should be removed once all patches > > currently in flux still relying on platform_get_irq_optional() are > > fixed. > > Hm... I'm afraid that with this #define they would never get fixed... :-) Agree. The problems I have listed in another reply should be fixed at once by the same series. -- With Best Regards, Andy Shevchenko