From: Rob Herring <robh@kernel.org>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>,
Madalin Bucur <madalin.bucur@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net 2/4] dt-bindings: net: Document fsl,erratum-a009885
Date: Thu, 20 Jan 2022 20:08:20 -0600 [thread overview]
Message-ID: <YeoVlBEWWlqDf7NG@robh.at.kernel.org> (raw)
In-Reply-To: <20220118215054.2629314-3-tobias@waldekranz.com>
On Tue, Jan 18, 2022 at 10:50:51PM +0100, Tobias Waldekranz wrote:
> Update FMan binding documentation with the newly added workaround for
> erratum A-009885.
>
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
> Documentation/devicetree/bindings/net/fsl-fman.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl-fman.txt b/Documentation/devicetree/bindings/net/fsl-fman.txt
> index c00fb0d22c7b..020337f3c05f 100644
> --- a/Documentation/devicetree/bindings/net/fsl-fman.txt
> +++ b/Documentation/devicetree/bindings/net/fsl-fman.txt
> @@ -410,6 +410,15 @@ PROPERTIES
> The settings and programming routines for internal/external
> MDIO are different. Must be included for internal MDIO.
>
> +- fsl,erratum-a009885
Adding errata properties doesn't work because then you have to update
your dtb to fix the issue where as if you use the compatible property
(specific to the SoC) you can fix the issue with just a (stable) kernel
update.
Yes, I see we already have some, but doesn't mean we need more of them.
> + Usage: optional
> + Value type: <boolean>
> + Definition: Indicates the presence of the A009885
> + erratum describing that the contents of MDIO_DATA may
> + become corrupt unless it is read within 16 MDC cycles
> + of MDIO_CFG[BSY] being cleared, when performing an
> + MDIO read operation.
> +
> - fsl,erratum-a011043
> Usage: optional
> Value type: <boolean>
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2022-01-21 2:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 21:50 [PATCH v2 net 0/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885 Tobias Waldekranz
2022-01-18 21:50 ` [PATCH v2 net 1/4] " Tobias Waldekranz
2022-01-18 21:50 ` [PATCH v2 net 2/4] dt-bindings: net: Document fsl,erratum-a009885 Tobias Waldekranz
2022-01-21 2:08 ` Rob Herring [this message]
2022-01-21 12:30 ` Tobias Waldekranz
2022-01-18 21:50 ` [PATCH v2 net 3/4] powerpc/fsl/dts: Enable WA for erratum A-009885 on fman3l MDIO buses Tobias Waldekranz
2022-01-18 21:50 ` [PATCH v2 net 4/4] net/fsl: xgmac_mdio: Fix incorrect iounmap when removing module Tobias Waldekranz
2022-01-19 16:30 ` [PATCH v2 net 0/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeoVlBEWWlqDf7NG@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).