From: Sergei Trofimovich <slyich@gmail.com>
To: netdev@vger.kernel.org
Subject: atl1c drivers run 'napi/eth%d-385' named threads with unsubstituted %d
Date: Fri, 21 Jan 2022 21:57:47 +0000 [thread overview]
Message-ID: <YessW5YR285JeLf5@nz> (raw)
Hia atl1c maintainers!
This cosmetics bothered me for some time: atl1c driver
shows unexpanded % in kernel thread names. Looks like a
minor bug:
$ ping -f 172.16.0.1 # host1
$ top # host2
...
621 root 20 0 0 0 0 S 11.0 0.0 0:05.01 napi/eth%d-385
622 root 20 0 0 0 0 S 5.6 0.0 0:02.64 napi/eth%d-386
...
Was happening for a few years. Likely not a recent regression.
System:
- linux-5.16.1
- x86_64
- 02:00.0 Ethernet controller: Qualcomm Atheros AR8151 v2.0 Gigabit Ethernet (rev c0)
From what I understand thread name comes from somewhere around:
net/core/dev.c:
int dev_set_threaded(struct net_device *dev, bool threaded)
...
err = napi_kthread_create(napi);
...
static int napi_kthread_create(struct napi_struct *n)
...
n->thread = kthread_run(napi_threaded_poll, n, "napi/%s-%d",
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:
static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
...
dev_set_threaded(netdev, true);
${somewhere} (not sure where):
...
strcpy(netdev->name, "eth%d");
I was not able to pinpoint where expansion should ideally happen.
Looks like many driver do `strcpy(netdev->name, "eth%d");` style
initialization and almost none call `dev_set_threaded(netdev, true);`.
Can you help me find it out how it should be fixed?
Thank you!
--
Sergei
next reply other threads:[~2022-01-21 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 21:57 Sergei Trofimovich [this message]
2022-01-21 23:45 ` atl1c drivers run 'napi/eth%d-385' named threads with unsubstituted %d Andrew Lunn
2022-01-22 1:03 ` Stephen Hemminger
2022-01-22 1:53 ` Andrew Lunn
2022-01-22 12:12 ` Sergei Trofimovich
2022-01-22 15:54 ` Andrew Lunn
2022-01-22 19:40 ` Andrew Lunn
2022-01-22 22:01 ` Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YessW5YR285JeLf5@nz \
--to=slyich@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).