From: Hangbin Liu <liuhangbin@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, David Ahern <dsahern@gmail.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Jonathan Toppins <jtoppins@redhat.com>
Subject: Re: [PATCH net-next 5/5] bonding: add new option ns_ip6_target
Date: Thu, 17 Feb 2022 09:25:46 +0800 [thread overview]
Message-ID: <Yg2kGkGKRTVXObYh@Laptop-X1> (raw)
In-Reply-To: <c13d92e2-3ac5-58cb-2b21-ebe03e640983@gmail.com>
On Wed, Feb 16, 2022 at 09:38:31AM -0800, Eric Dumazet wrote:
>
> On 2/16/22 00:08, Hangbin Liu wrote:
> > This patch add a new bonding option ns_ip6_target, which correspond
> > to the arp_ip_target. With this we set IPv6 targets and send IPv6 NS
> > request to determine the health of the link.
> >
> > For other related options like the validation, we still use
> > arp_validate, and will change to ns_validate later.
> >
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> > ---
> > Documentation/networking/bonding.rst | 11 +++
> > drivers/net/bonding/bond_netlink.c | 59 ++++++++++++
> > drivers/net/bonding/bond_options.c | 138 +++++++++++++++++++++++++++
> > drivers/net/bonding/bond_sysfs.c | 26 +++++
>
> Thanks for the patches !
>
> Do we really need to add sysfs parts, now rtnetlink is everywhere ?
For Bonding I think yes. Bonding has disallowed to config via module_param.
But there are still users using sysfs for bonding configuration.
Jay, Veaceslav, please correct me if you think we can stop using sysfs.
Thanks
Hangbin
next prev parent reply other threads:[~2022-02-17 1:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 8:08 [PATCH net-next 0/5] bonding: add IPv6 NS/NA monitor support Hangbin Liu
2022-02-16 8:08 ` [PATCH net-next 1/5] ipv6: separate ndisc_ns_create() from ndisc_send_ns() Hangbin Liu
2022-02-16 8:08 ` [PATCH net-next 2/5] Bonding: split bond_handle_vlan from bond_arp_send Hangbin Liu
2022-02-16 8:08 ` [PATCH net-next 3/5] bonding: add extra field for bond_opt_value Hangbin Liu
2022-02-16 8:08 ` [PATCH net-next 4/5] bonding: add new parameter ns_targets Hangbin Liu
2022-02-16 8:08 ` [PATCH net-next 5/5] bonding: add new option ns_ip6_target Hangbin Liu
2022-02-16 17:38 ` Eric Dumazet
2022-02-17 1:25 ` Hangbin Liu [this message]
2022-02-17 1:36 ` David Ahern
2022-02-17 4:26 ` Jay Vosburgh
2022-02-17 14:21 ` Jonathan Toppins
2022-02-17 18:00 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg2kGkGKRTVXObYh@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=jtoppins@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).