From: Leon Romanovsky <leon@kernel.org>
To: jmaloy@redhat.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
tipc-discussion@lists.sourceforge.net,
tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au,
tuong.t.lien@dektech.com.au, maloy@donjonn.com, xinl@redhat.com,
ying.xue@windriver.com, parthasarathy.bhuvaragan@gmail.com
Subject: Re: [v2,net] tipc: fix wrong notification node addresses
Date: Wed, 16 Feb 2022 09:08:38 +0200 [thread overview]
Message-ID: <Ygyi9rgXShc1MCoX@unreal> (raw)
In-Reply-To: <20220216020009.3404578-1-jmaloy@redhat.com>
On Tue, Feb 15, 2022 at 09:00:09PM -0500, jmaloy@redhat.com wrote:
> From: Jon Maloy <jmaloy@redhat.com>
>
> The previous bug fix had an unfortunate side effect that broke
> distribution of binding table entries between nodes. The updated
> tipc_sock_addr struct is also used further down in the same
> function, and there the old value is still the correct one.
>
> We fix this now.
>
> Fixes: 032062f363b4 ("tipc: fix wrong publisher node address in link publications")
>
Please don't put blank lines between Fixes and SOB lines.
Thanks
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
>
> ---
> v2: Copied n->addr to stack variable before leaving lock context, and
> using this in the notifications.
> ---
> net/tipc/node.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/net/tipc/node.c b/net/tipc/node.c
> index fd95df338da7..6ef95ce565bd 100644
> --- a/net/tipc/node.c
> +++ b/net/tipc/node.c
> @@ -403,7 +403,7 @@ static void tipc_node_write_unlock(struct tipc_node *n)
> u32 flags = n->action_flags;
> struct list_head *publ_list;
> struct tipc_uaddr ua;
> - u32 bearer_id;
> + u32 bearer_id, node;
>
> if (likely(!flags)) {
> write_unlock_bh(&n->lock);
> @@ -414,6 +414,7 @@ static void tipc_node_write_unlock(struct tipc_node *n)
> TIPC_LINK_STATE, n->addr, n->addr);
> sk.ref = n->link_id;
> sk.node = tipc_own_addr(net);
> + node = n->addr;
> bearer_id = n->link_id & 0xffff;
> publ_list = &n->publ_list;
>
> @@ -423,17 +424,17 @@ static void tipc_node_write_unlock(struct tipc_node *n)
> write_unlock_bh(&n->lock);
>
> if (flags & TIPC_NOTIFY_NODE_DOWN)
> - tipc_publ_notify(net, publ_list, sk.node, n->capabilities);
> + tipc_publ_notify(net, publ_list, node, n->capabilities);
>
> if (flags & TIPC_NOTIFY_NODE_UP)
> - tipc_named_node_up(net, sk.node, n->capabilities);
> + tipc_named_node_up(net, node, n->capabilities);
>
> if (flags & TIPC_NOTIFY_LINK_UP) {
> - tipc_mon_peer_up(net, sk.node, bearer_id);
> + tipc_mon_peer_up(net, node, bearer_id);
> tipc_nametbl_publish(net, &ua, &sk, sk.ref);
> }
> if (flags & TIPC_NOTIFY_LINK_DOWN) {
> - tipc_mon_peer_down(net, sk.node, bearer_id);
> + tipc_mon_peer_down(net, node, bearer_id);
> tipc_nametbl_withdraw(net, &ua, &sk, sk.ref);
> }
> }
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-02-16 7:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 2:00 [v2,net] tipc: fix wrong notification node addresses jmaloy
2022-02-16 7:08 ` Leon Romanovsky [this message]
2022-02-16 15:12 ` Jon Maloy
2022-02-16 16:12 ` Leon Romanovsky
2022-02-17 5:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygyi9rgXShc1MCoX@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=hoang.h.le@dektech.com.au \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=parthasarathy.bhuvaragan@gmail.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tung.q.nguyen@dektech.com.au \
--cc=tuong.t.lien@dektech.com.au \
--cc=xinl@redhat.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).