From: Miroslav Lichvar <mlichvar@redhat.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Gerhard Engleder <gerhard@engleder-embedded.com>,
yangbo.lu@nxp.com, davem@davemloft.net, kuba@kernel.org,
vinicius.gomes@intel.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 2/6] ptp: Request cycles for TX timestamp
Date: Thu, 24 Mar 2022 14:55:07 +0100 [thread overview]
Message-ID: <Yjx4O/nOwriKKoNj@localhost> (raw)
In-Reply-To: <20220324134934.GB27824@hoboy.vegasvil.org>
On Thu, Mar 24, 2022 at 06:49:34AM -0700, Richard Cochran wrote:
> On Tue, Mar 22, 2022 at 10:07:18PM +0100, Gerhard Engleder wrote:
> > --- a/include/linux/skbuff.h
> > +++ b/include/linux/skbuff.h
> > @@ -578,6 +578,9 @@ enum {
> > /* device driver is going to provide hardware time stamp */
> > SKBTX_IN_PROGRESS = 1 << 2,
> >
> > + /* generate hardware time stamp based on cycles if supported */
> > + SKBTX_HW_TSTAMP_USE_CYCLES = 1 << 3,
>
> Bit 4 used, but 3 was unused... interesting!
It seems the bit 3 and 5 were removed in commit 06b4feb37e64
("net: group skb_shinfo zerocopy related bits together.").
--
Miroslav Lichvar
next prev parent reply other threads:[~2022-03-24 13:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 21:07 [PATCH net-next v1 0/6] ptp: Support hardware clocks with additional free running time Gerhard Engleder
2022-03-22 21:07 ` [PATCH net-next v1 1/6] ptp: Add cycles support for virtual clocks Gerhard Engleder
2022-03-24 13:43 ` Richard Cochran
2022-03-24 19:39 ` Gerhard Engleder
2022-03-22 21:07 ` [PATCH net-next v1 2/6] ptp: Request cycles for TX timestamp Gerhard Engleder
2022-03-24 13:49 ` Richard Cochran
2022-03-24 13:55 ` Miroslav Lichvar [this message]
2022-03-24 19:43 ` Gerhard Engleder
2022-03-22 21:07 ` [PATCH net-next v1 3/6] ptp: Pass hwtstamp to ptp_convert_timestamp() Gerhard Engleder
2022-03-24 13:50 ` Richard Cochran
2022-03-22 21:07 ` [PATCH net-next v1 4/6] ethtool: Add kernel API for PHC index Gerhard Engleder
2022-03-24 13:51 ` Richard Cochran
2022-03-22 21:07 ` [PATCH net-next v1 5/6] ptp: Support late timestamp determination Gerhard Engleder
2022-03-23 0:54 ` kernel test robot
2022-03-23 1:05 ` kernel test robot
2022-03-23 2:06 ` kernel test robot
2022-03-24 14:01 ` Richard Cochran
2022-03-24 19:52 ` Gerhard Engleder
2022-03-25 0:04 ` Richard Cochran
2022-03-25 0:08 ` Richard Cochran
2022-03-25 20:51 ` Gerhard Engleder
2022-03-26 0:27 ` Vinicius Costa Gomes
2022-03-22 21:07 ` [PATCH net-next v1 6/6] tsnep: Add physical clock cycles support Gerhard Engleder
2022-03-25 0:01 ` [PATCH net-next v1 0/6] ptp: Support hardware clocks with additional free running time Vinicius Costa Gomes
2022-03-25 22:01 ` Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjx4O/nOwriKKoNj@localhost \
--to=mlichvar@redhat.com \
--cc=davem@davemloft.net \
--cc=gerhard@engleder-embedded.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vinicius.gomes@intel.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).