From: Andrew Lunn <andrew@lunn.ch>
To: Lukas Wunner <lukas@wunner.de>
Cc: Steve Glendinning <steve.glendinning@shawell.net>,
UNGLinuxDriver@microchip.com, Oliver Neukum <oneukum@suse.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Andre Edich <andre.edich@microchip.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Martyn Welch <martyn.welch@collabora.com>,
Gabriel Hojda <ghojda@yo2urs.ro>,
Christoph Fritz <chf.fritz@googlemail.com>,
Lino Sanfilippo <LinoSanfilippo@gmx.de>,
Philipp Rosenberger <p.rosenberger@kunbus.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH net-next 4/7] usbnet: smsc95xx: Avoid link settings race on interrupt reception
Date: Wed, 27 Apr 2022 13:50:42 +0200 [thread overview]
Message-ID: <YmkuEtyhwuayYdWJ@lunn.ch> (raw)
In-Reply-To: <28fd5a3d53a401cdf8ae0a116108702a46d2c7a2.1651037513.git.lukas@wunner.de>
> static void smsc95xx_status(struct usbnet *dev, struct urb *urb)
> @@ -607,7 +607,7 @@ static void smsc95xx_status(struct usbnet *dev, struct urb *urb)
> netif_dbg(dev, link, dev->net, "intdata: 0x%08X\n", intdata);
>
> if (intdata & INT_ENP_PHY_INT_)
> - usbnet_defer_kevent(dev, EVENT_LINK_RESET);
> + ;
> else
> netdev_warn(dev->net, "unexpected interrupt, intdata=0x%08X\n",
> intdata);
Hi Lukas
It would probably make sense to invert the condition and remove the ;
Andrew
next prev parent reply other threads:[~2022-04-27 11:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 5:48 [PATCH net-next 0/7] Polling be gone on LAN95xx Lukas Wunner
2022-04-27 5:48 ` [PATCH net-next 1/7] usbnet: Run unregister_netdev() before unbind() again Lukas Wunner
2022-04-27 7:44 ` Oliver Neukum
2022-04-27 7:45 ` Oliver Neukum
2022-04-27 5:48 ` [PATCH net-next 2/7] usbnet: smsc95xx: Don't clear read-only PHY interrupt Lukas Wunner
2022-04-27 5:48 ` [PATCH net-next 3/7] usbnet: smsc95xx: Don't reset PHY behind PHY driver's back Lukas Wunner
2022-04-27 5:48 ` [PATCH net-next 4/7] usbnet: smsc95xx: Avoid link settings race on interrupt reception Lukas Wunner
2022-04-27 11:50 ` Andrew Lunn [this message]
2022-04-27 5:48 ` [PATCH net-next 5/7] usbnet: smsc95xx: Forward PHY interrupts to PHY driver to avoid polling Lukas Wunner
2022-04-27 12:03 ` Andrew Lunn
2022-04-27 12:26 ` Andrew Lunn
2022-04-27 5:48 ` [PATCH net-next 6/7] net: phy: smsc: Cache interrupt mask Lukas Wunner
2022-04-27 12:14 ` Andrew Lunn
2022-04-27 12:51 ` Lukas Wunner
2022-04-27 5:48 ` [PATCH net-next 7/7] net: phy: smsc: Cope with hot-removal in interrupt handler Lukas Wunner
2022-04-27 7:46 ` Oliver Neukum
2022-04-27 12:37 ` [PATCH net-next 0/7] Polling be gone on LAN95xx Oleksij Rempel
2022-04-28 12:19 ` Lukas Wunner
2022-05-02 20:33 ` Ferry Toth
2022-05-03 8:26 ` Lukas Wunner
2022-05-03 14:26 ` Ferry Toth
2022-05-04 8:15 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmkuEtyhwuayYdWJ@lunn.ch \
--to=andrew@lunn.ch \
--cc=LinoSanfilippo@gmx.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andre.edich@microchip.com \
--cc=chf.fritz@googlemail.com \
--cc=davem@davemloft.net \
--cc=ghojda@yo2urs.ro \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas@wunner.de \
--cc=martyn.welch@collabora.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=oneukum@suse.com \
--cc=p.rosenberger@kunbus.com \
--cc=pabeni@redhat.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).