From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 157DCC433EF for ; Mon, 6 Jun 2022 21:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235000AbiFFV6V (ORCPT ); Mon, 6 Jun 2022 17:58:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231645AbiFFV6T (ORCPT ); Mon, 6 Jun 2022 17:58:19 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1C306B03E; Mon, 6 Jun 2022 14:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=iGWULO+VlekG2EE2L6kpDe23jcWGlAVkecnxC28q3Fk=; b=L6Jm7Qe2S7ghfnq07Yhxfp3OmP ae/Fd7W5GkLhDvCLrSFuHAeEaZ3dL+JPBs0gNCYZDLkMPymyVTUJTUlZW1ZUzlNd0SKEpBWpcLvKv 7tzm9jhXcqWeBQ52wvAhYHYyswSrRJOQPzXFRup1HtJjh9/2knOQrqZ72wSUFIgCPE1w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nyKjY-005qoa-Tb; Mon, 06 Jun 2022 23:58:00 +0200 Date: Mon, 6 Jun 2022 23:58:00 +0200 From: Andrew Lunn To: Rasmus Villemoes Cc: netdev@vger.kernel.org, Heiner Kallweit , Russell King , devicetree@vger.kernel.org, Rob Herring , Jakub Kicinski , "David S. Miller" , Dan Murphy , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/3] dt-bindings: dp83867: add binding for io_impedance_ctrl nvmem cell Message-ID: References: <20220606202220.1670714-1-linux@rasmusvillemoes.dk> <20220606202220.1670714-2-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220606202220.1670714-2-linux@rasmusvillemoes.dk> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > There is no documented mapping from the 32 possible values of the > IO_IMPEDANCE_CTRL field to values in the range 35-70 ohms There have been a few active TI engineers submitting patches to TI PHY drivers. Please could you reach out to them and ask if they can provide documentation. Having magic values in DT is not the preferred why to use it. Ideally you should store Ohms in the cell and convert to the register value. Andrew