From: Ido Schimmel <idosch@nvidia.com>
To: Juhee Kang <claudiajkang@gmail.com>
Cc: netdev@vger.kernel.org, tchornyi@marvell.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, petrm@nvidia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] mlxsw: use netif_is_any_bridge_port() instead of open code
Date: Thu, 21 Jul 2022 21:03:43 +0300 [thread overview]
Message-ID: <YtmU//3wdPm28LPl@shredder> (raw)
In-Reply-To: <20220721102648.2455-1-claudiajkang@gmail.com>
On Thu, Jul 21, 2022 at 07:26:47PM +0900, Juhee Kang wrote:
> The open code which is netif_is_bridge_port() || netif_is_ovs_port() is
> defined as a new helper function on netdev.h like netif_is_any_bridge_port
> that can check both IFF flags in 1 go. So use netif_is_any_bridge_port()
> function instead of open code. This patch doesn't change logic.
>
> Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2022-07-21 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 10:26 [PATCH net-next 1/2] mlxsw: use netif_is_any_bridge_port() instead of open code Juhee Kang
2022-07-21 10:26 ` [PATCH net-next 2/2] net: marvell: prestera: use netif_is_any_bridge_port " Juhee Kang
2022-07-21 18:03 ` Ido Schimmel [this message]
2022-07-22 21:17 ` [PATCH net-next 1/2] mlxsw: use netif_is_any_bridge_port() " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtmU//3wdPm28LPl@shredder \
--to=idosch@nvidia.com \
--cc=claudiajkang@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=tchornyi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).