netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] selftests:net:forwarding: Included install command
@ 2022-08-10  9:35 Piyush Thange
  2022-08-10  9:53 ` Siddh Raman Pant
  0 siblings, 1 reply; 3+ messages in thread
From: Piyush Thange @ 2022-08-10  9:35 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni
  Cc: shuah, vladimir.oltean, idosch, petrm, troglobit, amcohen,
	tobias, po-hsu.lin, netdev, linux-kselftest, linux-kernel,
	linux-kernel-mentees, Piyush Thange

If the execution is skipped due to "jq not installed" message then
the installation methods on different OS's have been provided with
this message.

Signed-off-by: Piyush Thange <pthange19@gmail.com>
---
 tools/testing/selftests/net/forwarding/lib.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
index 37ae49d47853..c4121856fe06 100755
--- a/tools/testing/selftests/net/forwarding/lib.sh
+++ b/tools/testing/selftests/net/forwarding/lib.sh
@@ -152,6 +152,14 @@ require_command()

 	if [[ ! -x "$(command -v "$cmd")" ]]; then
 		echo "SKIP: $cmd not installed"
+		if [[ $cmd == "jq" ]]; then
+			echo " Install on Debian based systems"
+			echo "	sudo apt -y install jq"
+			echo " Install on RHEL based systems"
+			echo "	sudo yum -y install jq"
+			echo " Install on Fedora based systems"
+			echo "	sudo dnf -y install jq"
+		fi
 		exit $ksft_skip
 	fi
 }
--
2.37.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] selftests:net:forwarding: Included install command
  2022-08-10  9:35 [PATCH] selftests:net:forwarding: Included install command Piyush Thange
@ 2022-08-10  9:53 ` Siddh Raman Pant
  2022-08-11  1:41   ` Hangbin Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Siddh Raman Pant @ 2022-08-10  9:53 UTC (permalink / raw)
  To: Piyush Thange
  Cc: davem, edumazet, kuba, pabeni, shuah, vladimir.oltean, idosch,
	petrm, troglobit, amcohen, tobias, po-hsu.lin, netdev,
	linux-kselftest, linux-kernel, linux-kernel-mentees

On Wed, 10 Aug 2022 15:05:08 +0530  Piyush Thange <pthange19@gmail.com>  wrote:
> If the execution is skipped due to "jq not installed" message then
> the installation methods on different OS's have been provided with
> this message.
> 
> Signed-off-by: Piyush Thange <pthange19@gmail.com>
> ---
>  tools/testing/selftests/net/forwarding/lib.sh | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
> index 37ae49d47853..c4121856fe06 100755
> --- a/tools/testing/selftests/net/forwarding/lib.sh
> +++ b/tools/testing/selftests/net/forwarding/lib.sh
> @@ -152,6 +152,14 @@ require_command()
> 
>  	if [[ ! -x "$(command -v "$cmd")" ]]; then
>  		echo "SKIP: $cmd not installed"
> +		if [[ $cmd == "jq" ]]; then
> +			echo " Install on Debian based systems"
> +			echo "	sudo apt -y install jq"
> +			echo " Install on RHEL based systems"
> +			echo "	sudo yum -y install jq"
> +			echo " Install on Fedora based systems"
> +			echo "	sudo dnf -y install jq"
> +		fi
>  		exit $ksft_skip
>  	fi
>  }
> --
> 2.37.1

This is very specific to `jq` command. What's special with `jq` and not
others? If methods have to be shown, they should be shown for all the
programs which are not installed.

Further, this limits the information to specific package managers and
systems in the userspace. Tomorrow a new system may come, which will
cause this list to grow, not to mention other existing package managers.
The kernel also doesn't have a role in it, so we should try to be generic
as much as possible.

Thanks,
Siddh

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] selftests:net:forwarding: Included install command
  2022-08-10  9:53 ` Siddh Raman Pant
@ 2022-08-11  1:41   ` Hangbin Liu
  0 siblings, 0 replies; 3+ messages in thread
From: Hangbin Liu @ 2022-08-11  1:41 UTC (permalink / raw)
  To: Siddh Raman Pant
  Cc: Piyush Thange, davem, edumazet, kuba, pabeni, shuah,
	vladimir.oltean, idosch, petrm, troglobit, amcohen, tobias,
	po-hsu.lin, netdev, linux-kselftest, linux-kernel,
	linux-kernel-mentees

On Wed, Aug 10, 2022 at 03:23:15PM +0530, Siddh Raman Pant wrote:
> On Wed, 10 Aug 2022 15:05:08 +0530  Piyush Thange <pthange19@gmail.com>  wrote:
> > If the execution is skipped due to "jq not installed" message then
> > the installation methods on different OS's have been provided with
> > this message.
> > 
> > Signed-off-by: Piyush Thange <pthange19@gmail.com>
> > ---
> >  tools/testing/selftests/net/forwarding/lib.sh | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
> > index 37ae49d47853..c4121856fe06 100755
> > --- a/tools/testing/selftests/net/forwarding/lib.sh
> > +++ b/tools/testing/selftests/net/forwarding/lib.sh
> > @@ -152,6 +152,14 @@ require_command()
> > 
> >  	if [[ ! -x "$(command -v "$cmd")" ]]; then
> >  		echo "SKIP: $cmd not installed"
> > +		if [[ $cmd == "jq" ]]; then
> > +			echo " Install on Debian based systems"
> > +			echo "	sudo apt -y install jq"
> > +			echo " Install on RHEL based systems"
> > +			echo "	sudo yum -y install jq"
> > +			echo " Install on Fedora based systems"
> > +			echo "	sudo dnf -y install jq"
> > +		fi
> >  		exit $ksft_skip
> >  	fi
> >  }
> > --
> > 2.37.1
> 
> This is very specific to `jq` command. What's special with `jq` and not
> others? If methods have to be shown, they should be shown for all the
> programs which are not installed.

Agree. The user could decide if jq should be install via REQUIRE_JQ. There are
also other cmds that vendor may not build by default. I didn't see any
selftests need to handle the installation. The users should takes care of it.

require_command() has takes care most of the needed cmds. If we want to
improve the user's experience for the needed cmds. I think add the needed cmds
to README file is better.

Thanks
Hangbin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-11  1:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-10  9:35 [PATCH] selftests:net:forwarding: Included install command Piyush Thange
2022-08-10  9:53 ` Siddh Raman Pant
2022-08-11  1:41   ` Hangbin Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).