From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E52C00140 for ; Thu, 11 Aug 2022 02:05:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233602AbiHKCFI (ORCPT ); Wed, 10 Aug 2022 22:05:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229924AbiHKCFH (ORCPT ); Wed, 10 Aug 2022 22:05:07 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D84105C9E5 for ; Wed, 10 Aug 2022 19:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=mDIvTx2qAvASK3DTy3T6hYmY5KVdGLU3qkdQr8+u5r8=; b=uwwSVduwm0HtYYGars1req+bgS QhwAEoy5sr59ydX4x5Hi4yZTB4kT09Lej0tTtO2qUllnE4NTb+H2cRdDI2TiPi7ie5EKEJePiyBP6 izsL297YDdvcZLRthbcRccUmjc+drA8DXvJV3ZLgGgphNOHNj7g9wQqb7fsV7TnoZ5ZI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oLxZH-00Cz9k-32; Thu, 11 Aug 2022 04:05:03 +0200 Date: Thu, 11 Aug 2022 04:05:03 +0200 From: Andrew Lunn To: Richard Cochran Cc: =?iso-8859-1?B?Q3Pza+Fz?= Bence , netdev@vger.kernel.org, Fugang Duan Subject: Re: [PATCH] fec: Restart PPS after link state change Message-ID: References: <20220809124119.29922-1-csokas.bence@prolan.hu> <299d74d5-2d56-23f6-affc-78bb3ae3e03c@prolan.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 10, 2022 at 06:37:19PM -0700, Richard Cochran wrote: > On Thu, Aug 11, 2022 at 02:05:39AM +0200, Andrew Lunn wrote: > > > Yes. We use PPS to synchronize devices on a common backplane. We use PTP to > > > sync this PPS to a master clock. But if PTP sync drops out, we wouldn't want > > > the backplane-level synchronization to fail. The PPS needs to stay on as > > > long as userspace *explicitly* disables it, regardless of what happens to > > > the link. > > > > We need the PTP Maintainers view on that. I don't know if that is > > normal or not. > > IMO the least surprising behavior is that once enabled, a feature > stays on until explicitly disabled. O.K, thanks for the response. Your answer is a bit surprising to me. To me, an interface which is administratively down is completely inactive. The action to down it should disable everything. So your answer also implies PPS can be used before the interface is set administratively up? Andrew