From: Lee Jones <lee@kernel.org>
To: Colin Foster <colin.foster@in-advantage.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
UNGLinuxDriver@microchip.com,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [RFC v1 net-next 8/8] net: dsa: ocelot: add external ocelot switch control
Date: Mon, 12 Sep 2022 11:51:14 +0100 [thread overview]
Message-ID: <Yx8PIsInsR7oQqgh@google.com> (raw)
In-Reply-To: <20220911200244.549029-9-colin.foster@in-advantage.com>
On Sun, 11 Sep 2022, Colin Foster wrote:
> Add control of an external VSC7512 chip by way of the ocelot-mfd interface.
>
> Currently the four copper phy ports are fully functional. Communication to
> external phys is also functional, but the SGMII / QSGMII interfaces are
> currently non-functional.
>
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> ---
>
> v1 from previous RFC:
> * Remove unnecessary byteorder and kconfig header includes.
> * Create OCELOT_EXT_PORT_MODE_SERDES macro to match vsc9959.
> * Utilize readx_poll_timeout for SYS_RESET_CFG_MEM_INIT.
> * *_io_res struct arrays have been moved to the MFD files.
> * Changes to utilize phylink_generic_validate() have been squashed.
> * dev_err_probe() is used in the probe function.
> * Make ocelot_ext_switch_of_match static.
> * Relocate ocelot_ext_ops structure to be next to vsc7512_info, to
> match what was done in other felix drivers.
> * Utilize dev_get_regmap() instead of the obsolete
> ocelot_init_regmap_from_resource() routine.
>
> ---
> drivers/mfd/ocelot-core.c | 3 +
> drivers/net/dsa/ocelot/Kconfig | 14 ++
> drivers/net/dsa/ocelot/Makefile | 5 +
> drivers/net/dsa/ocelot/ocelot_ext.c | 254 ++++++++++++++++++++++++++++
> include/soc/mscc/ocelot.h | 2 +
> 5 files changed, 278 insertions(+)
> create mode 100644 drivers/net/dsa/ocelot/ocelot_ext.c
>
> diff --git a/drivers/mfd/ocelot-core.c b/drivers/mfd/ocelot-core.c
> index aa7fa21b354c..b7b9f6855f74 100644
> --- a/drivers/mfd/ocelot-core.c
> +++ b/drivers/mfd/ocelot-core.c
> @@ -188,6 +188,9 @@ static const struct mfd_cell vsc7512_devs[] = {
> .use_of_reg = true,
> .num_resources = ARRAY_SIZE(vsc7512_miim1_resources),
> .resources = vsc7512_miim1_resources,
> + }, {
> + .name = "ocelot-ext-switch",
> + .of_compatible = "mscc,vsc7512-ext-switch",
> },
> };
Please separate this out into its own patch.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-09-12 10:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 20:02 [RFC v1 net-next 0/8] add support for the the vsc7512 internal copper phys Colin Foster
2022-09-11 20:02 ` [RFC v1 net-next 1/8] net: mscc: ocelot: expose ocelot wm functions Colin Foster
2022-09-11 20:02 ` [RFC v1 net-next 2/8] net: mscc: ocelot: expose regfield definition to be used by other drivers Colin Foster
2022-09-12 15:47 ` Vladimir Oltean
2022-09-16 17:44 ` Colin Foster
2022-09-16 22:36 ` Vladimir Oltean
2022-09-11 20:02 ` [RFC v1 net-next 3/8] net: mscc: ocelot: expose stats layout " Colin Foster
2022-09-11 20:02 ` [RFC v1 net-next 4/8] net: mscc: ocelot: expose vcap_props structure Colin Foster
2022-09-11 20:02 ` [RFC v1 net-next 5/8] net: dsa: felix: add configurable device quirks Colin Foster
2022-09-11 20:02 ` [RFC v1 net-next 6/8] net: dsa: felix: populate mac_capabilities for all ports Colin Foster
2022-09-12 8:48 ` Russell King (Oracle)
2022-09-12 10:16 ` Vladimir Oltean
2022-09-12 11:41 ` Vladimir Oltean
2022-09-12 15:32 ` Russell King (Oracle)
2022-09-12 15:35 ` Colin Foster
2022-09-12 15:47 ` Colin Foster
2022-09-12 15:52 ` Vladimir Oltean
2022-09-12 16:04 ` Colin Foster
2022-09-11 20:02 ` [RFC v1 net-next 7/8] mfd: ocelot: add regmaps for ocelot_ext Colin Foster
2022-09-12 17:08 ` Vladimir Oltean
2022-09-12 19:04 ` Colin Foster
2022-09-12 20:23 ` Vladimir Oltean
2022-09-12 21:03 ` Colin Foster
2022-09-12 21:53 ` Vladimir Oltean
2022-09-11 20:02 ` [RFC v1 net-next 8/8] net: dsa: ocelot: add external ocelot switch control Colin Foster
2022-09-12 10:51 ` Lee Jones [this message]
2022-09-12 15:31 ` Colin Foster
2022-09-12 17:21 ` Vladimir Oltean
2022-09-12 19:13 ` Colin Foster
2022-09-16 16:55 ` Colin Foster
2022-09-16 22:31 ` Vladimir Oltean
2022-09-16 23:10 ` Colin Foster
2022-09-20 2:58 ` Colin Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx8PIsInsR7oQqgh@google.com \
--to=lee@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).