From: Dominique Martinet <asmadeus@codewreck.org>
To: Christian Schoenebeck <linux_oss@crudebyte.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
syzbot <syzbot+8b41a1365f1106fd0f33@syzkaller.appspotmail.com>,
v9fs-developer@lists.sourceforge.net,
syzkaller-bugs@googlegroups.com, netdev@vger.kernel.org
Subject: Re: [PATCH] 9p/trans_fd: always use O_NONBLOCK read/write
Date: Fri, 7 Oct 2022 10:03:59 +0900 [thread overview]
Message-ID: <Yz96//Gf4tCteJLm@codewreck.org> (raw)
In-Reply-To: <4870107.4IDB3aycit@silver>
Christian Schoenebeck wrote on Thu, Oct 06, 2022 at 04:55:23PM +0200:
> > diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
> > index e758978b44be..9870597da583 100644
> > --- a/net/9p/trans_fd.c
> > +++ b/net/9p/trans_fd.c
> > @@ -821,11 +821,13 @@ static int p9_fd_open(struct p9_client *client, int
> > rfd, int wfd) goto out_free_ts;
> > if (!(ts->rd->f_mode & FMODE_READ))
> > goto out_put_rd;
> > + ts->rd->f_flags |= O_NONBLOCK;
>
> ... I think this deserves a short comment like:
>
> /* prevent hung task with pipes */
Good point, I've sneaked in this comment:
/* prevent workers from hanging on IO when fd is a pipe */
https://github.com/martinetd/linux/commit/ef575281b21e9a34dfae544a187c6aac2ae424a9
> Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com>
Thank you!
--
Dominique
prev parent reply other threads:[~2022-10-07 1:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 19:28 INFO: task hung in p9_fd_close syzbot
2019-09-21 16:19 ` syzbot
2022-08-26 15:27 ` [PATCH] 9p/trans_fd: always use O_NONBLOCK read/write Tetsuo Handa
2022-08-27 6:11 ` [PATCH v2] 9p/trans_fd: perform read/write with TIF_SIGPENDING set Tetsuo Handa
2022-09-01 15:23 ` Christian Schoenebeck
2022-09-01 22:25 ` Tetsuo Handa
2022-09-03 23:39 ` Dominique Martinet
2022-09-04 0:27 ` Tetsuo Handa
2022-10-07 1:40 ` Dominique Martinet
2022-10-07 11:52 ` Tetsuo Handa
2022-10-06 14:55 ` [PATCH] 9p/trans_fd: always use O_NONBLOCK read/write Christian Schoenebeck
2022-10-07 1:03 ` Dominique Martinet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz96//Gf4tCteJLm@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=syzbot+8b41a1365f1106fd0f33@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).