From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0632C7618A for ; Tue, 14 Mar 2023 13:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232190AbjCNNHO (ORCPT ); Tue, 14 Mar 2023 09:07:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232000AbjCNNGz (ORCPT ); Tue, 14 Mar 2023 09:06:55 -0400 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90F0364267 for ; Tue, 14 Mar 2023 06:03:40 -0700 (PDT) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1pc44R-0002yc-00; Tue, 14 Mar 2023 13:48:03 +0100 Date: Tue, 14 Mar 2023 12:47:59 +0000 From: Daniel Golle To: Felix Fietkau Cc: Frank Wunderlich , Mark Lee , Sean Wang , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , John Crispin , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [BUG] MTK SoC Ethernet throughput TX only ~620Mbit/s since 6.2-rc1 Message-ID: References: <4a229d53-f058-115a-afc6-dd544a0dedf2@nbd.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a229d53-f058-115a-afc6-dd544a0dedf2@nbd.name> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Felix, On Tue, Mar 14, 2023 at 11:30:53AM +0100, Felix Fietkau wrote: > On 07.03.23 19:32, Frank Wunderlich wrote: > > Hi, > > > > i've noticed that beginning on 6.2-rc1 the throughput on my Bananapi-R2 and Bananapi-R3 goes from 940Mbit/s down do 620Mbit/s since 6.2-rc1. > > Only TX (from SBC PoV) is affected, RX is still 940Mbit/s. > > > > i bisected this to this commit: > > > > f63959c7eec3151c30a2ee0d351827b62e742dcb ("net: ethernet: mtk_eth_soc: implement multi-queue support for per-port queues") > > > > Daniel reported me that this is known so far and they need assistance from MTK and i should report it officially. > > > > As far as i understand it the commit should fix problems with clients using non-GBE speeds (10/100 Mbit/s) on the Gbit-capable dsa > > interfaces (mt753x connected) behind the mac, but now the Gigabit speed is no more reached. > > I see no CRC/dropped packets, retransmitts or similar. > > > > after reverting the commit above i get 940Mbit like in rx direction, but this will introduce the problems mentioned above so this not a complete fix. > I don't have a BPI-R2, but I tested on BPI-R3 and can't reproduce this > issue. Do you see it on all ports, or only on specific ones? I also can't reproduce this if unsing any of the gigE ports wired via MT7531 on the R3. However, I can reproduce the issue if using a 1 GBit/s SFP module in slot SFP1 of the R3 (connected directly to GMAC2/eth1). Users have reported this also to be a problem also on MT7622 on devices directly connecting a PHY (and not using MT7531). In all cases, reverting the commit above fixes the issue. Cheers Daniel