From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0015749F for ; Fri, 9 Jun 2023 07:17:57 +0000 (UTC) Received: from a.mx.secunet.com (a.mx.secunet.com [62.96.220.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EACB72722 for ; Fri, 9 Jun 2023 00:17:55 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id C3A04207AC; Fri, 9 Jun 2023 09:17:53 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SP8RySaLw1J5; Fri, 9 Jun 2023 09:17:53 +0200 (CEST) Received: from mailout2.secunet.com (mailout2.secunet.com [62.96.220.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 4D69F20861; Fri, 9 Jun 2023 09:17:53 +0200 (CEST) Received: from cas-essen-02.secunet.de (unknown [10.53.40.202]) by mailout2.secunet.com (Postfix) with ESMTP id 46C4580004A; Fri, 9 Jun 2023 09:17:53 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-02.secunet.de (10.53.40.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 9 Jun 2023 09:17:53 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 9 Jun 2023 09:17:52 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 881BB3182B23; Fri, 9 Jun 2023 09:17:52 +0200 (CEST) Date: Fri, 9 Jun 2023 09:17:52 +0200 From: Steffen Klassert To: Maciej =?utf-8?Q?=C5=BBenczykowski?= CC: Maciej =?utf-8?Q?=C5=BBenczykowski?= , "Linux Network Development Mailing List" , Sabrina Dubroca , Jakub Kicinski , Benedict Wong , Yan Yan Subject: Re: [PATCH v2] xfrm: fix inbound ipv4/udp/esp packets to UDPv6 dualstack sockets Message-ID: References: <20221026083203.2214468-1-zenczykowski@gmail.com> <20230605110654.809655-1-maze@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230605110654.809655-1-maze@google.com> X-ClientProxiedBy: cas-essen-01.secunet.de (10.53.40.201) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Jun 05, 2023 at 04:06:54AM -0700, Maciej Żenczykowski wrote: > Before Linux v5.8 an AF_INET6 SOCK_DGRAM (udp/udplite) socket > with SOL_UDP, UDP_ENCAP, UDP_ENCAP_ESPINUDP{,_NON_IKE} enabled > would just unconditionally use xfrm4_udp_encap_rcv(), afterwards > such a socket would use the newly added xfrm6_udp_encap_rcv() > which only handles IPv6 packets. > > Cc: Sabrina Dubroca > Cc: Steffen Klassert > Cc: Jakub Kicinski > Cc: Benedict Wong > Cc: Yan Yan > Fixes: 0146dca70b87 ('xfrm: add support for UDPv6 encapsulation of ESP') > Signed-off-by: Maciej Żenczykowski Applied, thanks a lot Maciej!