netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tao Liu <taoliu828@163.com>
To: Cosmin Ratiu <cratiu@nvidia.com>
Cc: roid@nvidia.com, paulb@nvidia.com, vladbu@nvidia.com,
	dchumak@nvidia.com, saeedm@nvidia.com, taoliu828@163.com,
	netdev@vger.kernel.org
Subject: Re: Report mlx5_core crash
Date: Thu, 8 Feb 2024 11:12:23 +0800	[thread overview]
Message-ID: <ZcRGl758ek_at4Ha@liutao02-mac.local> (raw)
In-Reply-To: <055cc6cbe8521fdfd753612d6d6d76857550e731.camel@nvidia.com>

On 02/07  , Cosmin Ratiu wrote:
> On Tue, 2024-02-06 at 15:01 +0800, Tao Liu wrote:
> > On 01/31  , Tao Liu wrote:
> > > Hi Mellanox team,
> > > 
> > >    We hit a crash in mlx5_core which is similar with commit
> > >    de31854ece17 ("net/mlx5e: Fix nullptr on deleting mirroring rule").
> > >    But they are different cases, our case is:
> > >    in_port(...),eth(...) \
> > > actions:set(tunnel(...)),vxlan_sys_4789,set(tunnel(...)),vxlan_sys_4789,...
> > > 
> > >      BUG: kernel NULL pointer dereference, address: 0000000000000270
> > >      RIP: 0010:del_sw_hw_rule+0x29/0x190 [mlx5_core]
> 
> Hello,
> 
> I'll help you find and fix the problem.
> Your core dump analysis was very useful, but not sufficient to find the
> cause of the crash. Would you mind sharing a set of reproduction steps
> so we can debug this further?
> 
> Thank you,
> Cosmin.

Hi Cosmin,

Thanks for your reply.

It's hard to reproduce the crash directly.  In our case the rule forwards ip
broadcast traffic to 5 vxlan remotes. And driver creates 6 mlx5_flow_rule
which include 5 mlx5_pkt_reformat and 1 counter.
It triggers only when two *dr_action in struct mlx5_pkt_reformat have same
lower 32 bits, which determined by memory allocation.

Is it possible that we do some fault injection in unit test to reproduce?

Best regards,
Tao


  reply	other threads:[~2024-02-08  3:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3016cbe9-57e9-4ef4-a979-ac0db1b3ef31@163.com>
2024-01-31 14:19 ` Report mlx5_core crash Tao Liu
2024-02-06  7:01   ` Tao Liu
2024-02-06 23:42     ` Saeed Mahameed
2024-02-07 10:33     ` Cosmin Ratiu
2024-02-08  3:12       ` Tao Liu [this message]
2024-02-27 17:39         ` Cosmin Ratiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZcRGl758ek_at4Ha@liutao02-mac.local \
    --to=taoliu828@163.com \
    --cc=cratiu@nvidia.com \
    --cc=dchumak@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=paulb@nvidia.com \
    --cc=roid@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=vladbu@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).