netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Ahern <dsahern@gmail.com>,
	Po-Hsu Lin <po-hsu.lin@canonical.com>
Subject: Re: [BUG] selftests/net: icmp_redirect.sh: 12 out of 40 test result with [FAIL]
Date: Mon, 18 Mar 2024 10:38:35 +0800	[thread overview]
Message-ID: <ZfepK3xItcv3ARVV@Laptop-X1> (raw)
In-Reply-To: <dfb4b2fa-1728-43f2-ad73-f06145399fc9@alu.unizg.hr>

Hi Mirsad,

On Sat, Mar 16, 2024 at 11:59:54PM +0100, Mirsad Todorovac wrote:
> Hi,
> 
> With the commit v6.8-11167-g4438a810f396 in vanilla torvalds tree, there seem to be problems with
> the icmp_redirect.sh tests.
> 
> The iproute2-next tools were used, commit 7a6d30c95da9.
> 
> # timeout set to 3600
> # selftests: net: icmp_redirect.sh
> #
> # ###########################################################################
> # Legacy routing
> # ###########################################################################
> #
> # TEST: IPv4: redirect exception                                      [FAIL]
> # TEST: IPv6: redirect exception                                      [ OK ]
> # TEST: IPv4: redirect exception plus mtu                             [FAIL]
> # TEST: IPv6: redirect exception plus mtu                             [ OK ]
> # TEST: IPv4: routing reset                                           [ OK ]
> # TEST: IPv6: routing reset                                           [ OK ]
> # TEST: IPv4: mtu exception                                           [ OK ]
> # TEST: IPv6: mtu exception                                           [ OK ]
> # TEST: IPv4: mtu exception plus redirect                             [FAIL]
> # TEST: IPv6: mtu exception plus redirect                             [ OK ]
> #
...
> #
> # TEST: IPv4: redirect exception                                      [FAIL]
> # TEST: IPv6: redirect exception                                      [ OK ]
> # TEST: IPv4: redirect exception plus mtu                             [FAIL]
> # TEST: IPv6: redirect exception plus mtu                             [ OK ]
> # TEST: IPv4: routing reset                                           [ OK ]
> # TEST: IPv6: routing reset                                           [ OK ]
> # TEST: IPv4: mtu exception                                           [ OK ]
> # TEST: IPv6: mtu exception                                           [ OK ]
> # TEST: IPv4: mtu exception plus redirect                             [FAIL]
> # TEST: IPv6: mtu exception plus redirect                             [ OK ]
> #
> # Tests passed:  28
> # Tests failed:  12
> # Tests xfailed:   0
> not ok 45 selftests: net: icmp_redirect.sh # exit=1
> 
> These errors are not introduced with this commit, but were already present at least in 6.8-rc7.

I tried kernel 6.8 with net tree. All passed.

# ./icmp_redirect.sh

###########################################################################
Legacy routing
###########################################################################

TEST: IPv4: redirect exception                                      [ OK ]
TEST: IPv6: redirect exception                                      [ OK ]
TEST: IPv4: redirect exception plus mtu                             [ OK ]
TEST: IPv6: redirect exception plus mtu                             [ OK ]
TEST: IPv4: routing reset                                           [ OK ]
TEST: IPv6: routing reset                                           [ OK ]
TEST: IPv4: mtu exception                                           [ OK ]
TEST: IPv6: mtu exception                                           [ OK ]
TEST: IPv4: mtu exception plus redirect                             [ OK ]
TEST: IPv6: mtu exception plus redirect                             [ OK ]
...
TEST: IPv4: redirect exception                                      [ OK ]
TEST: IPv6: redirect exception                                      [ OK ]
TEST: IPv4: redirect exception plus mtu                             [ OK ]
TEST: IPv6: redirect exception plus mtu                             [ OK ]
TEST: IPv4: routing reset                                           [ OK ]
TEST: IPv6: routing reset                                           [ OK ]
TEST: IPv4: mtu exception                                           [ OK ]
TEST: IPv6: mtu exception                                           [ OK ]
TEST: IPv4: mtu exception plus redirect                             [ OK ]
TEST: IPv6: mtu exception plus redirect                             [ OK ]

Tests passed:  40
Tests failed:   0
Tests xfailed:   0

# uname -r
6.8.0-virtme

You can try enable verbose output and see where the failure occurred.

Wild guess, the last change of icmp_redirect is my netns update. Maybe there
are something default sysctl settings in netns cause the error?

Thanks
Hangbin

  reply	other threads:[~2024-03-18  2:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-16 22:59 [BUG] selftests/net: icmp_redirect.sh: 12 out of 40 test result with [FAIL] Mirsad Todorovac
2024-03-18  2:38 ` Hangbin Liu [this message]
2024-03-18 14:42   ` David Ahern
2024-03-19  4:53     ` Mirsad Todorovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZfepK3xItcv3ARVV@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mirsad.todorovac@alu.unizg.hr \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=po-hsu.lin@canonical.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).