From: Jiri Pirko <jiri@resnulli.us>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH net 0/6] wireguard fixes for 6.9-rc1
Date: Mon, 18 Mar 2024 12:31:31 +0100 [thread overview]
Message-ID: <ZfgmE5cIh-hrjJCX@nanopsycho> (raw)
In-Reply-To: <20240314224911.6653-1-Jason@zx2c4.com>
Thu, Mar 14, 2024 at 11:49:05PM CET, Jason@zx2c4.com wrote:
>Hey netdev,
>
>This series has four WireGuard fixes:
>
>1) Annotate a data race that KCSAN found by using READ_ONCE/WRITE_ONCE,
> which has been causing syzkaller noise.
>
>2) Use the generic netdev tstats allocation and stats getters instead of
> doing this within the driver.
>
>3) Explicitly check a flag variable instead of an empty list in the
> netlink code, to prevent a UaF situation when paging through GET
> results during a remove-all SET operation.
>
>4) Set a flag in the RISC-V CI config so the selftests continue to boot.
>
>Please apply these!
>
>Thanks,
>Jason
>
>
>Breno Leitao (2):
> wireguard: device: leverage core stats allocator
> wireguard: device: remove generic .ndo_get_stats64
>
>Jason A. Donenfeld (3):
> wireguard: netlink: check for dangling peer via is_dead instead of
> empty list
> wireguard: netlink: access device through ctx instead of peer
> wireguard: selftests: set RISCV_ISA_FALLBACK on riscv{32,64}
>
>Nikita Zhandarovich (1):
> wireguard: receive: annotate data-race around
> receiving_counter.counter
Looks fine to me.
set-
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
>
> drivers/net/wireguard/device.c | 11 ++---------
> drivers/net/wireguard/netlink.c | 10 +++++-----
> drivers/net/wireguard/receive.c | 6 +++---
> .../selftests/wireguard/qemu/arch/riscv32.config | 1 +
> .../selftests/wireguard/qemu/arch/riscv64.config | 1 +
> 5 files changed, 12 insertions(+), 17 deletions(-)
>
>--
>2.44.0
>
>
next prev parent reply other threads:[~2024-03-18 11:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 22:49 [PATCH net 0/6] wireguard fixes for 6.9-rc1 Jason A. Donenfeld
2024-03-14 22:49 ` [PATCH net 1/6] wireguard: receive: annotate data-race around receiving_counter.counter Jason A. Donenfeld
2024-03-14 22:49 ` [PATCH net 2/6] wireguard: device: leverage core stats allocator Jason A. Donenfeld
2024-03-14 22:49 ` [PATCH net 3/6] wireguard: device: remove generic .ndo_get_stats64 Jason A. Donenfeld
2024-03-14 22:49 ` [PATCH net 4/6] wireguard: netlink: check for dangling peer via is_dead instead of empty list Jason A. Donenfeld
2024-03-14 22:49 ` [PATCH net 5/6] wireguard: netlink: access device through ctx instead of peer Jason A. Donenfeld
2024-03-14 22:49 ` [PATCH net 6/6] wireguard: selftests: set RISCV_ISA_FALLBACK on riscv{32,64} Jason A. Donenfeld
2024-03-18 11:31 ` Jiri Pirko [this message]
2024-03-19 10:30 ` [PATCH net 0/6] wireguard fixes for 6.9-rc1 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfgmE5cIh-hrjJCX@nanopsycho \
--to=jiri@resnulli.us \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).