From: Hauke Mehrtens <hauke@hauke-m.de>
To: Eric Dumazet <edumazet@google.com>,
Koen Vandeputte <koen.vandeputte@ncentric.com>
Cc: netdev <netdev@vger.kernel.org>, Greg KH <greg@kroah.com>
Subject: Re: crash since commit "net/flow_dissector: switch to siphash"
Date: Mon, 18 Nov 2019 01:11:49 +0100 [thread overview]
Message-ID: <a020f6bf-e0d1-22af-46f7-34f44e417fef@hauke-m.de> (raw)
In-Reply-To: <CANn89iJ6OOQG8PZ1qDXP-EsOLKip44rcQhn+LNTUM1HezRwvNA@mail.gmail.com>
On 11/15/19 6:09 PM, Eric Dumazet wrote:
> On Fri, Nov 15, 2019 at 3:30 AM Koen Vandeputte
> <koen.vandeputte@ncentric.com> wrote:
>>
>>
>> On 13.11.19 15:50, Eric Dumazet wrote:
>>> On Wed, Nov 13, 2019 at 3:52 AM Koen Vandeputte
>>> <koen.vandeputte@ncentric.com> wrote:
>>>> Hi Eric,
>>>>
>>>> I'm currently testing kernel 4.14.153 bump for OpenWrt and noticed splat
>>>> below on my testing boards.
>>>> They all reboot continuously nearly immediately when linked.
>>>>
>>>> It feels like it's tied to a commit of yours [1]
>>> Have you tried current upstream kernels ?
>>
>> No.
>>
>> This board is only supported on OpenWrt currently using 4.14 and it's
>> not natively supported by upstream.
>>
>>>
>>> Is is a backport issue, or a bug in original commit ?
>>
>> No idea .. and I'm not profound enough on that part of the code to judge
>> this,
>>
>> which is why I'm consulting your expert opinion.
>>
>>>
>>> Can you give us gcc version ?
>> 7.4.0
>>>
>>> Can you check what SIPHASH_ALIGNMENT value is at compile time ?
>> 8 (exposed it in dmesg on boot)
>
> Please ask OpenWrt specialists for support.
>
> The code is probably mishandled by the compiler.
>
> siphash() is supposed to handle misaligned data just fine, and
> net/core/flow_dissector.c tries hard to align the keys anyway.
Hi Koen,
This is probably related to backports for the wireless driver which uses
its own fq.h and fq_impl.h implementation and this is now conflicting
with Eric's patch which got backported.
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v4.14.154&id=a9de6f42e945cdb24b59c7ab7ebad1eba6cb5875
I saw this as a compile warning when creating a new backports version
and created this patch:
https://www.spinics.net/lists/backports/msg04930.html
This is for the other way around.
I will try to create a patch for OpenWrt backports tomorrow to fix this
problem and I am also planning to create a new backports release in the
next few days.
Hauke
next prev parent reply other threads:[~2019-11-18 0:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 11:52 crash since commit "net/flow_dissector: switch to siphash" Koen Vandeputte
2019-11-13 14:50 ` Eric Dumazet
2019-11-15 11:30 ` Koen Vandeputte
2019-11-15 17:09 ` Eric Dumazet
2019-11-18 0:11 ` Hauke Mehrtens [this message]
2019-11-18 14:12 ` Koen Vandeputte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a020f6bf-e0d1-22af-46f7-34f44e417fef@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=edumazet@google.com \
--cc=greg@kroah.com \
--cc=koen.vandeputte@ncentric.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).