From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Jakub Kicinski <kuba@kernel.org>, Hemant Kumar <hemantk@codeaurora.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
davem@davemloft.net, netdev@vger.kernel.org,
manivannan.sadhasivam@linaro.org, eric.dumazet@gmail.com,
Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: Re: [PATCH v6 1/2] bus: mhi: Add mhi_queue_is_full function
Date: Fri, 23 Oct 2020 10:19:44 -0600 [thread overview]
Message-ID: <a03293b6-71bb-50f7-870c-2db463e6499e@codeaurora.org> (raw)
In-Reply-To: <20201023084425.22bbf069@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On 10/23/2020 9:44 AM, Jakub Kicinski wrote:
> On Thu, 22 Oct 2020 20:06:37 -0700 Hemant Kumar wrote:
>>> @@ -1173,6 +1173,17 @@ int mhi_queue_buf(struct mhi_device *mhi_dev, enum dma_data_direction dir,
>>> }
>>> EXPORT_SYMBOL_GPL(mhi_queue_buf);
>>>
>>> +bool mhi_queue_is_full(struct mhi_device *mhi_dev, enum dma_data_direction dir)
>>> +{
>>> + struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
>>> + struct mhi_chan *mhi_chan = (dir == DMA_TO_DEVICE) ?
>>> + mhi_dev->ul_chan : mhi_dev->dl_chan;
>>> + struct mhi_ring *tre_ring = &mhi_chan->tre_ring;
>>> +
>>> + return mhi_is_ring_full(mhi_cntrl, tre_ring);
>>> +}
>>> +EXPORT_SYMBOL_GPL(mhi_queue_is_full);
>>>
>> i was wondering if you can make use of mhi_get_free_desc() API (pushed
>> as part of MHI UCI - User Control Interface driver) here?
>
> Let me ask you one more time. Where is this MHI UCI code you're talking
> about?
https://lkml.org/lkml/2020/10/22/186
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-10-23 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 9:20 [PATCH v6 1/2] bus: mhi: Add mhi_queue_is_full function Loic Poulain
2020-10-16 9:20 ` [PATCH v6 2/3] net: Add mhi-net driver Loic Poulain
2020-10-16 18:06 ` Jakub Kicinski
2020-10-17 0:52 ` Hemant Kumar
2020-10-17 1:37 ` Jakub Kicinski
2020-10-23 3:06 ` [PATCH v6 1/2] bus: mhi: Add mhi_queue_is_full function Hemant Kumar
2020-10-23 15:44 ` Jakub Kicinski
2020-10-23 16:19 ` Jeffrey Hugo [this message]
[not found] ` <CAMZdPi_NZ5PaONpePHHFOosiuQ50R0_o3bymwzKfp2DJ37BCig@mail.gmail.com>
2020-10-23 19:24 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a03293b6-71bb-50f7-870c-2db463e6499e@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=bbhatt@codeaurora.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hemantk@codeaurora.org \
--cc=kuba@kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).