From: David Bauer <mail@david-bauer.net>
To: Michael Walle <michael@walle.cc>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next v2] net: phy: at803x: fix probe error if copper page is selected
Date: Tue, 20 Apr 2021 13:04:53 +0200 [thread overview]
Message-ID: <a0e5c38d-9a60-5b48-48bf-ff4884adebb4@david-bauer.net> (raw)
In-Reply-To: <20210420102929.13505-1-michael@walle.cc>
Hi,
On 4/20/21 12:29 PM, Michael Walle wrote:
> The commit c329e5afb42f ("net: phy: at803x: select correct page on
> config init") selects the copper page during probe. This fails if the
> copper page was already selected. In this case, the value of the copper
> page (which is 1) is propagated through phy_restore_page() and is
> finally returned for at803x_probe(). Fix it, by just using the
> at803x_page_write() directly.
Ouch, i didn't spot that. Thanks for taking care.
>
> Also in case of an error, the regulator is not disabled and leads to a
> WARN_ON() when the probe fails. This couldn't happen before, because
> at803x_parse_dt() was the last call in at803x_probe(). It is hard to
> see, that the parse_dt() actually enables the regulator. Thus move the
> regulator_enable() to the probe function and undo it in case of an
> error.
>
> Fixes: c329e5afb42f ("net: phy: at803x: select correct page on config init")
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: David Bauer <mail@david-bauer.net>
Best
David
> ---
> Changes since v1:
> - take the bus lock
>
> drivers/net/phy/at803x.c | 23 +++++++++++++++++------
> 1 file changed, 17 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index e0f56850edc5..32af52dd5aed 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -554,10 +554,6 @@ static int at803x_parse_dt(struct phy_device *phydev)
> phydev_err(phydev, "failed to get VDDIO regulator\n");
> return PTR_ERR(priv->vddio);
> }
> -
> - ret = regulator_enable(priv->vddio);
> - if (ret < 0)
> - return ret;
> }
>
> return 0;
> @@ -579,15 +575,30 @@ static int at803x_probe(struct phy_device *phydev)
> if (ret)
> return ret;
>
> + if (priv->vddio) {
> + ret = regulator_enable(priv->vddio);
> + if (ret < 0)
> + return ret;
> + }
> +
> /* Some bootloaders leave the fiber page selected.
> * Switch to the copper page, as otherwise we read
> * the PHY capabilities from the fiber side.
> */
> if (at803x_match_phy_id(phydev, ATH8031_PHY_ID)) {
> - ret = phy_select_page(phydev, AT803X_PAGE_COPPER);
> - ret = phy_restore_page(phydev, AT803X_PAGE_COPPER, ret);
> + phy_lock_mdio_bus(phydev);
> + ret = at803x_write_page(phydev, AT803X_PAGE_COPPER);
> + phy_unlock_mdio_bus(phydev);
> + if (ret)
> + goto err;
> }
>
> + return 0;
> +
> +err:
> + if (priv->vddio)
> + regulator_disable(priv->vddio);
> +
> return ret;
> }
>
>
next prev parent reply other threads:[~2021-04-20 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 10:29 [PATCH net-next v2] net: phy: at803x: fix probe error if copper page is selected Michael Walle
2021-04-20 11:04 ` David Bauer [this message]
2021-04-21 0:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0e5c38d-9a60-5b48-48bf-ff4884adebb4@david-bauer.net \
--to=mail@david-bauer.net \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).