From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 495D5C433DF for ; Sun, 17 May 2020 02:38:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 280D1204EF for ; Sun, 17 May 2020 02:38:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726956AbgEQCh7 (ORCPT ); Sat, 16 May 2020 22:37:59 -0400 Received: from smtprelay0026.hostedemail.com ([216.40.44.26]:52030 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726919AbgEQCh7 (ORCPT ); Sat, 16 May 2020 22:37:59 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 9CB0B100E7B40; Sun, 17 May 2020 02:37:57 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: lip88_b22d3cfaaa49 X-Filterd-Recvd-Size: 4718 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf01.hostedemail.com (Postfix) with ESMTPA; Sun, 17 May 2020 02:37:56 +0000 (UTC) Message-ID: Subject: Re: [PATCH V6 20/20] net: ks8851: Drop define debug and pr_fmt() From: Joe Perches To: Marek Vasut , netdev@vger.kernel.org Cc: "David S . Miller" , Lukas Wunner , Petr Stetiar , YueHaibing Date: Sat, 16 May 2020 19:37:55 -0700 In-Reply-To: <7447d18e-cd81-b98e-a0d9-1059b60a3cf0@denx.de> References: <20200517003354.233373-1-marex@denx.de> <20200517003354.233373-21-marex@denx.de> <7447d18e-cd81-b98e-a0d9-1059b60a3cf0@denx.de> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 2020-05-17 at 04:28 +0200, Marek Vasut wrote: > On 5/17/20 4:01 AM, Joe Perches wrote: > > On Sun, 2020-05-17 at 02:33 +0200, Marek Vasut wrote: > > > Drop those debug statements from both drivers. They were there since > > > at least 2011 and enabled by default, but that's likely wrong. > > [] > > > diff --git a/drivers/net/ethernet/micrel/ks8851_par.c b/drivers/net/ethernet/micrel/ks8851_par.c > > [] > > > -#define DEBUG > > > > Dropping the #define DEBUG lines will cause a behavior > > change for the netdev/netif_dbg uses as these messages > > will no longer be output by default. > > Is that a problem ? Dunno. I don't use nor debug these drivers. You just say that's likely wrong, but I wonder if that's really true. You also don't mention in your patch commit message that the output logging actually does change as if the DEBUG define has no effect. Prior to this change these were output at KERN_DEBUG $ git grep -A1 _dbg drivers/net/ethernet/micrel/ks8851.c drivers/net/ethernet/micrel/ks8851.c: netif_dbg(ks, hw, ks->netdev, "setting power mode %d\n", pwrmode); drivers/net/ethernet/micrel/ks8851.c- -- drivers/net/ethernet/micrel/ks8851.c: netif_dbg(ks, rx_status, ks->netdev, drivers/net/ethernet/micrel/ks8851.c- "%s: %d@%p\n", __func__, len, buff); -- drivers/net/ethernet/micrel/ks8851.c: * ks8851_dbg_dumpkkt - dump initial packet contents to debug drivers/net/ethernet/micrel/ks8851.c- * @ks: The device state -- drivers/net/ethernet/micrel/ks8851.c: * Dump the initial data from the packet to dev_dbg(). drivers/net/ethernet/micrel/ks8851.c-*/ drivers/net/ethernet/micrel/ks8851.c:static void ks8851_dbg_dumpkkt(struct ks8851_net *ks, u8 *rxpkt) drivers/net/ethernet/micrel/ks8851.c-{ drivers/net/ethernet/micrel/ks8851.c: netdev_dbg(ks->netdev, drivers/net/ethernet/micrel/ks8851.c- "pkt %02x%02x%02x%02x %02x%02x%02x%02x %02x%02x%02x%02x\n", -- drivers/net/ethernet/micrel/ks8851.c: netif_dbg(ks, rx_status, ks->netdev, drivers/net/ethernet/micrel/ks8851.c- "%s: %d packets\n", __func__, rxfc); -- drivers/net/ethernet/micrel/ks8851.c: netif_dbg(ks, rx_status, ks->netdev, drivers/net/ethernet/micrel/ks8851.c- "rx: stat 0x%04x, len 0x%04x\n", rxstat, rxlen); -- drivers/net/ethernet/micrel/ks8851.c: ks8851_dbg_dumpkkt(ks, rxpkt); drivers/net/ethernet/micrel/ks8851.c- -- drivers/net/ethernet/micrel/ks8851.c: netif_dbg(ks, intr, ks->netdev, drivers/net/ethernet/micrel/ks8851.c- "%s: status 0x%04x\n", __func__, status); -- drivers/net/ethernet/micrel/ks8851.c: netif_dbg(ks, intr, ks->netdev, drivers/net/ethernet/micrel/ks8851.c- "%s: txspace %d\n", __func__, ks->tx_space); -- drivers/net/ethernet/micrel/ks8851.c: netif_dbg(ks, tx_queued, ks->netdev, "%s: skb %p, %d@%p, irq %d\n", drivers/net/ethernet/micrel/ks8851.c- __func__, txp, txp->len, txp->data, irq); -- drivers/net/ethernet/micrel/ks8851.c: netif_dbg(ks, ifup, ks->netdev, "opening\n"); drivers/net/ethernet/micrel/ks8851.c- -- drivers/net/ethernet/micrel/ks8851.c: netif_dbg(ks, ifup, ks->netdev, "network device up\n"); drivers/net/ethernet/micrel/ks8851.c- -- drivers/net/ethernet/micrel/ks8851.c: netif_dbg(ks, ifdown, ks->netdev, drivers/net/ethernet/micrel/ks8851.c- "%s: freeing txb %p\n", __func__, txb); -- drivers/net/ethernet/micrel/ks8851.c: netif_dbg(ks, tx_queued, ks->netdev, drivers/net/ethernet/micrel/ks8851.c- "%s: skb %p, %d@%p\n", __func__, skb, skb->len, skb->data);