From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0072AC433E0 for ; Fri, 31 Jul 2020 17:31:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D59992245C for ; Fri, 31 Jul 2020 17:31:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QI7R7ijI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387466AbgGaRbp (ORCPT ); Fri, 31 Jul 2020 13:31:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732970AbgGaRbo (ORCPT ); Fri, 31 Jul 2020 13:31:44 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF82DC061574; Fri, 31 Jul 2020 10:31:44 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id p1so17765166pls.4; Fri, 31 Jul 2020 10:31:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fQJ4K4WTAcUQrIZ+9ByJXhYGj+Opn9+r2wnqSlYmSBM=; b=QI7R7ijI9AZSDPbEh3LMc3YQofbpFJMhFT6cxjz1oqbQKVmG4CM2BSdq2qVMctkd55 kjkOfrSanPeMHc3SeMGVdn0Rc8mGARN0Ilg52nMYM1N/qwLlTKhlecu/6rbQ8A8sfgzL x6dCJRdSumPzC2QnN8CIy7w3BhSjbp285ULapanyGZXg6ttP5LAgKbd+dRdidEdQ3XTK Qwlj/2AVs7nMFxu6Sz5VHVOuRk2eGTIjOVQw9WGell4N7gEJGD/ElR3bRAkmGnV1FTXT e1fORWiLm8V9jVYbEFKi/R6hWnJwfi23eK4YFDQ/oxlr9w2rXaO9Wkbkzd3uuhYjtYER SY3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fQJ4K4WTAcUQrIZ+9ByJXhYGj+Opn9+r2wnqSlYmSBM=; b=HYzEoR8NHggmfpv8QBF5CHUMDzfU1l3IvQJyUEP16uPycarrEOpgaKxC3BSYWbUdwY ybmWgN02P37+fAyb1KOemoAaZOZLZPrcs6M/EwDWx8dE8dCdi6peRPttIYy6s/ISt7u7 z8GQPBxtyrrLltKL/hwIZS0knk+9rhKFP4Q1mdCqGCnDfWzP+jLF12L1Jm9d146MHt6A 9trGPH8kb/bk9EmCOqPBT3X9z0IuD8AwpRTZ+FnSjF2QQMDYchcWk76cTtgtRUJE0ahn Zh9b0dlfBAYm38DL9vyJvJJkD8bovHOMv1r30P9+yusQfYCmxSnbS1M5ihirIIS11Nzs q3Og== X-Gm-Message-State: AOAM533zJ57LPjGWB+lxNoFUBxqUBnWFp6dl1MIgEUjV+Nz1lbQJWTXd xcqDZV/OMUM6aWZqG+5EDZU= X-Google-Smtp-Source: ABdhPJwN1D1QXUWHzVcer4sHJ0Gl2Si8s98l/xxCxm314xCSJZkDLMkSokeuZkp8aWjGmIf3ozRyQw== X-Received: by 2002:a17:90a:2210:: with SMTP id c16mr2992127pje.65.1596216704297; Fri, 31 Jul 2020 10:31:44 -0700 (PDT) Received: from [10.1.10.11] (c-73-241-150-58.hsd1.ca.comcast.net. [73.241.150.58]) by smtp.gmail.com with ESMTPSA id y17sm10590971pfe.30.2020.07.31.10.31.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2020 10:31:43 -0700 (PDT) Subject: Re: [PATCH v3 bpf-next 1/9] tcp: Use a struct to represent a saved_syn To: Eric Dumazet , Martin KaFai Lau Cc: bpf , Alexei Starovoitov , Daniel Borkmann , kernel-team , Lawrence Brakmo , Neal Cardwell , netdev , Yuchung Cheng References: <20200730205657.3351905-1-kafai@fb.com> <20200730205704.3352619-1-kafai@fb.com> From: Eric Dumazet Message-ID: Date: Fri, 31 Jul 2020 10:31:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/31/20 8:57 AM, Eric Dumazet wrote: > On Thu, Jul 30, 2020 at 1:57 PM Martin KaFai Lau wrote: >> >> The TCP_SAVE_SYN has both the network header and tcp header. >> The total length of the saved syn packet is currently stored in >> the first 4 bytes (u32) of an array and the actual packet data is >> stored after that. >> >> A latter patch will add a bpf helper that allows to get the tcp header > > s/latter/later/ Sorry, brain fart. I am using a different wording, that is all ;)