From: Rodolfo Giometti <giometti@enneenne.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: Possible bug into DSA2 code.
Date: Wed, 20 Feb 2019 08:54:01 +0100 [thread overview]
Message-ID: <a2f6fa7e-49c3-cb3f-43eb-8ab248b0bb63@enneenne.com> (raw)
In-Reply-To: <20190219000340.GJ14879@lunn.ch>
On 19/02/2019 01:03, Andrew Lunn wrote:
>> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
>> index 54a5b660640a..bb46ebbb2bb8 100644
>> --- a/drivers/net/dsa/mv88e6xxx/chip.c
>> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
>> @@ -2399,7 +2399,7 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)
>> int i;
>>
>> chip->ds = ds;
>> - ds->slave_mii_bus = mv88e6xxx_default_mdio_bus(chip);
>> + ds->slave_mii_bus = NULL;
>>
>> mutex_lock(&chip->reg_lock);
>>
>> Is that right?
>
> Hi Rodolfo
>
> Humm, that needs testing. There are two used combinations you need to
> test:
>
> No MDIO node in device tree, e.g.
> arch/arm/boot/dts/kirkwood-dir665.dts
>
> MDIO node in device tree, e.g:
> arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
I'm sorry but I haven't such boards... :'(
> There is a third combination which will appear soon. There is only the
> external mdio bus in device tree:
>
> port@9 {
> reg = <9>;
> label = "eth_cu_1000_2";
> phy-handle = <&phy9>;
> phy-mode = "sgmii";
> managed = "in-band-status";
> };
> };
>
> mdio1 {
> compatible = "marvell,mv88e6xxx-mdio-external";
> #address-cells = <1>;
> #size-cells = <0>;
>
> phy9: phy9@0 {
> compatible = "ethernet-phy-ieee802.3-c45";
> pinctrl-0 = <&pinctrl_gpio_phy9>;
> pinctrl-names = "default";
> interrupt-parent = <&gpio2>;
> interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
> reg = <0>;
> };
> };
>
> Here port 9 uses the external MDIO bus and all the other ports
> implicitly make use of the internal MDIO bus.
Mmm... maybe should code into drivers/net/dsa/mv88e6xxx use private data to hold
used mdio busses instead of ds->slave_mii_bus pointer?
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
next prev parent reply other threads:[~2019-02-20 7:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a121e6b5-03cd-da9e-42e8-41c68e12babe@enneenne.com>
2019-02-09 8:24 ` Possible bug into DSA2 code Rodolfo Giometti
2019-02-09 19:34 ` Andrew Lunn
2019-02-10 11:45 ` Rodolfo Giometti
2019-02-11 17:28 ` Florian Fainelli
2019-02-11 17:51 ` Rodolfo Giometti
2019-02-11 18:01 ` Florian Fainelli
2019-02-11 19:13 ` Florian Fainelli
2019-02-18 10:38 ` Rodolfo Giometti
2019-02-19 0:03 ` Andrew Lunn
2019-02-20 7:54 ` Rodolfo Giometti [this message]
2019-02-20 15:02 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2f6fa7e-49c3-cb3f-43eb-8ab248b0bb63@enneenne.com \
--to=giometti@enneenne.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).