From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1BD5C4320A for ; Thu, 29 Jul 2021 18:30:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8293060F21 for ; Thu, 29 Jul 2021 18:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230151AbhG2Sa2 (ORCPT ); Thu, 29 Jul 2021 14:30:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbhG2SaY (ORCPT ); Thu, 29 Jul 2021 14:30:24 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D1CBC061765; Thu, 29 Jul 2021 11:30:20 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id a26so12693250lfr.11; Thu, 29 Jul 2021 11:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TAdDceQVUngpDy2MWRCVwVSd4gWYibtnRV4Hhvmmdh0=; b=YeSrQBszugRcb6ZAsSkIjI/e1Xc8dq5OGiFuA8MX6PTrynJsOWS8RuTEdPLRucyOyt /tP1azLQsOd59ZUOUgyc9DKYJA1e4nnZuAb7I6GczrNuLCCfsfZ0YwjG8lGA5sa7I2YY QyEvrxydqu+OZUq5TneiipOcYPjMG9Ui5flXNmp8q4FSAUyIoEquTzI5f/jI2i0ix+VH M9p7MhjJEv2bmAuO2C7FVvNhriRntaAnp5ggweLspV4ClkpoHGyNn1AP0FQ8FD+A6VQB cHRh1MVnjiQmgnYriS3Ct7rMq/V/8iOv2vN+elmlMx3XCsSSfG4DnkHe79dhMP42tr8c tjmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TAdDceQVUngpDy2MWRCVwVSd4gWYibtnRV4Hhvmmdh0=; b=NHidhQBnYmPm6Cp93jyLCRXwEZ9HWjp2xAhpcA9l8mbRCFu6k88tI3RgPNaCNN66FS JWtXUwocBnooveeAQSMLThkxbPkixWHH7RTWajfWS+SC4FNoZ9n0Fc0d8wXB8GRVKc91 UwwX7ddwgSPpa48YnYQZywWJtWIVkNTFMy4j8FpuKVEm8O+ySJPVjbycEkRIdOLBT4eM s3eLZPImPJg0G+Fdh8axRYv5K1+UHHl0imwg7YTh3t9gvl09zIFAYGph0pf1qAZyzzP4 uASC0+sZpxKVurhv3JS9QdC2pYWbr6s0Nz2KzgxlXS1+HAslL44QN4BbUIKg8Kcg1eyA heFg== X-Gm-Message-State: AOAM530DRa7JgsM5z1UtfQDHi4s2KDvi75mhY2hI41QLhxsGPvBn4HMI GmO53/Zfu84iZs71e/09QPQ= X-Google-Smtp-Source: ABdhPJyNVKuxYkF1eyM/3Jmwa9WLVrqX2XkfuAqWLnBH9LQymGCGyw/3G8nO+BOVL9vDmYBgo0h7CA== X-Received: by 2002:ac2:5149:: with SMTP id q9mr4660117lfd.476.1627583418256; Thu, 29 Jul 2021 11:30:18 -0700 (PDT) Received: from [192.168.1.102] ([31.173.80.187]) by smtp.gmail.com with ESMTPSA id p21sm370068lfo.199.2021.07.29.11.30.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 11:30:17 -0700 (PDT) Subject: Re: [PATCH net-next 10/18] ravb: Factorise ravb_ring_format function To: Biju Das , "David S. Miller" , Jakub Kicinski Cc: Geert Uytterhoeven , Sergey Shtylyov , Adam Ford , Andrew Lunn , Yuusuke Ashizuka , Yoshihiro Shimoda , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Chris Paterson , Biju Das , Prabhakar Mahadev Lad References: <20210722141351.13668-1-biju.das.jz@bp.renesas.com> <20210722141351.13668-11-biju.das.jz@bp.renesas.com> From: Sergei Shtylyov Message-ID: Date: Thu, 29 Jul 2021 21:30:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210722141351.13668-11-biju.das.jz@bp.renesas.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/22/21 5:13 PM, Biju Das wrote: > The ravb_ring_format function uses extended descriptor in rx for > R-Car where as it use normal descriptor for RZ/G2L. Factorise > rx ring buffer buildup to extend the support for later SoC. > > Signed-off-by: Biju Das > Reviewed-by: Lad Prabhakar > --- > drivers/net/ethernet/renesas/ravb.h | 1 + > drivers/net/ethernet/renesas/ravb_main.c | 34 +++++++++++++++--------- > 2 files changed, 23 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h > index 3a9cf6e8671a..a3258c5d0c3d 100644 > --- a/drivers/net/ethernet/renesas/ravb.h > +++ b/drivers/net/ethernet/renesas/ravb.h > @@ -990,6 +990,7 @@ enum ravb_chip_id { > > struct ravb_ops { > void (*ring_free)(struct net_device *ndev, int q); > + void (*ring_format)(struct net_device *ndev, int q); Like I said, we don't need another indirection.... also both ops are for RX. [...] > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index a3b8b243fd54..c23f0d420c70 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -311,26 +311,15 @@ static void ravb_ring_free(struct net_device *ndev, int q) > } > > /* Format skb and descriptor buffer for Ethernet AVB */ > -static void ravb_ring_format(struct net_device *ndev, int q) > +static void ravb_ring_format_rx(struct net_device *ndev, int rxq) How about ravb_rx_ring_format(struct net_device *ndev, int q)? [...] MBR, Sergei