From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A59B9C54EED for ; Mon, 30 Jan 2023 17:10:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237474AbjA3RKA (ORCPT ); Mon, 30 Jan 2023 12:10:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235466AbjA3RJ7 (ORCPT ); Mon, 30 Jan 2023 12:09:59 -0500 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66878402D0 for ; Mon, 30 Jan 2023 09:09:58 -0800 (PST) Received: by mail-il1-x132.google.com with SMTP id l7so3512620ilf.0 for ; Mon, 30 Jan 2023 09:09:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D0NwTkchautTwr2b39Io8oodrygOmHFDn/d5ivG/ofE=; b=IbZSTyOzumgCwaGh9+gOtUafb9wtJruo+OSMMousEq/WYpP7T0K4AzaxxeDJNvPgEw fllUmTju0J0bFbRsQRFV2oTIlltQYtI/daPtMOVtq0SnyxWBT4A2LHrjDMVemIfOcZfw wWlNz5NCKoRqRyAx2OOnh2UEj4yvrRXKVKR+E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D0NwTkchautTwr2b39Io8oodrygOmHFDn/d5ivG/ofE=; b=j9Tw7rXW6PEucoX7ivLkRYHOTC2OJSYebeImhOR3x+1ohifyQelq8/sYMZRhbyEejM 5Q6ZbgcjSeeBDEt1odGW5i/p310ohB8YodqNFQLH6S4dSE015UdAeWsCMVymMEVUWk/Y a8TLlomRSagBflC5zBZx6xkq1ffZ9BQxuXWadR9BzJcwMFImSfNfQ28juT67OWF9BjuU 2Zg4zsPSY2Om4anjTohyP0vupq0WChYBDA2DuR4M14bmv16gkIPfB6UKc8hScR8Lbaxw +5MmCKlQyhqj0aiL1sCEFQUOFVNaHBcErKtPl8wDJMzlaPdLcUa4FzCYisloLePs0k4N jxKQ== X-Gm-Message-State: AO0yUKXAJSDkNIxV+BZCBgx94Q+H9SpMUbytdUeeNbXVF96cNeJ0JKdZ nw5T0lMU5aZ1JneBJjFZVWCV5Q== X-Google-Smtp-Source: AK7set+Ka13TT616pYhAC6agDWa038VNKK0nbrDwsXNkOBLBm9pJSvboUARiJD/s2Nd4khZm7Kg4fA== X-Received: by 2002:a05:6e02:1a46:b0:310:ecea:b488 with SMTP id u6-20020a056e021a4600b00310eceab488mr1021838ilv.3.1675098597745; Mon, 30 Jan 2023 09:09:57 -0800 (PST) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id h19-20020a056638339300b003a2a167e7d9sm4392002jav.96.2023.01.30.09.09.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 09:09:57 -0800 (PST) Message-ID: Date: Mon, 30 Jan 2023 10:09:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 02/34] selftests: bpf: Fix incorrect kernel headers search path Content-Language: en-US To: Mathieu Desnoyers , Alexei Starovoitov Cc: Shuah Khan , "open list:KERNEL SELFTEST FRAMEWORK" , Ingo Molnar , Alexei Starovoitov , Daniel Borkmann , LKML , stable , bpf , Networking , Shuah Khan References: <20230127135755.79929-1-mathieu.desnoyers@efficios.com> <20230127135755.79929-3-mathieu.desnoyers@efficios.com> <4defb04e-ddcb-b344-6e9f-35023dee0d2a@linuxfoundation.org> <7023e3f3-bfd3-5842-5624-b1fd21576591@efficios.com> From: Shuah Khan In-Reply-To: <7023e3f3-bfd3-5842-5624-b1fd21576591@efficios.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/30/23 10:00, Mathieu Desnoyers wrote: > On 2023-01-30 11:26, Alexei Starovoitov wrote: >> On Mon, Jan 30, 2023 at 8:12 AM Shuah Khan wrote: >>> >>> On 1/27/23 06:57, Mathieu Desnoyers wrote: >>>> Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents >>>> building against kernel headers from the build environment in scenarios >>>> where kernel headers are installed into a specific output directory >>>> (O=...). >>>> >>>> Signed-off-by: Mathieu Desnoyers >>>> Cc: Shuah Khan >>>> Cc: linux-kselftest@vger.kernel.org >>>> Cc: Ingo Molnar >>>> Cc:     [5.18+] >>>> --- >>>>    tools/testing/selftests/bpf/Makefile | 2 +- >>>>    1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile >>>> index c22c43bbee19..6998c816afef 100644 >>>> --- a/tools/testing/selftests/bpf/Makefile >>>> +++ b/tools/testing/selftests/bpf/Makefile >>>> @@ -327,7 +327,7 @@ endif >>>>    CLANG_SYS_INCLUDES = $(call get_sys_includes,$(CLANG),$(CLANG_TARGET_ARCH)) >>>>    BPF_CFLAGS = -g -Werror -D__TARGET_ARCH_$(SRCARCH) $(MENDIAN)               \ >>>>             -I$(INCLUDE_DIR) -I$(CURDIR) -I$(APIDIR)                   \ >>>> -          -I$(abspath $(OUTPUT)/../usr/include) >>>> +          $(KHDR_INCLUDES) >>>> >>>>    CLANG_CFLAGS = $(CLANG_SYS_INCLUDES) \ >>>>               -Wno-compare-distinct-pointer-types >>> >>> >>> >>> Adding bpf maintainers - bpf patches usually go through bpf tree. >>> >>> Acked-by: Shuah Khan >> >> Please resubmit as separate patch with [PATCH bpf-next] subj >> and cc bpf@vger, so that BPF CI can test it on various architectures >> and config combinations. > > Hi Shuah, > > Do you have means to resubmit it on your end, or should I do it ? > Hi Mathieu, Please go ahead and resubmit. thanks, -- Shuah