From: Daniel Borkmann <daniel@iogearbox.net>
To: Amritha Nambiar <amritha.nambiar@intel.com>,
netdev@vger.kernel.org, davem@davemloft.net, ast@kernel.org
Cc: kafai@fb.com, sridhar.samudrala@intel.com
Subject: Re: [bpf-next PATCH v2] bpf: Add rx_queue_mapping to bpf_sock
Date: Sat, 23 May 2020 01:34:49 +0200 [thread overview]
Message-ID: <a648441b-6546-c904-d2a0-583b4c9e77d7@iogearbox.net> (raw)
In-Reply-To: <159017210823.76267.780907394437543496.stgit@anambiarhost.jf.intel.com>
On 5/22/20 8:28 PM, Amritha Nambiar wrote:
> Add "rx_queue_mapping" to bpf_sock. This gives read access for the
> existing field (sk_rx_queue_mapping) of struct sock from bpf_sock.
> Semantics for the bpf_sock rx_queue_mapping access are similar to
> sk_rx_queue_get(), i.e the value NO_QUEUE_MAPPING is not allowed
> and -1 is returned in that case.
This adds the "what this patch does" but could you also add a description for
the use-case in here?
> v2: fixed build error for CONFIG_XPS wrapping, reported by
> kbuild test robot <lkp@intel.com>
>
> Signed-off-by: Amritha Nambiar <amritha.nambiar@intel.com>
> ---
> include/uapi/linux/bpf.h | 1 +
> net/core/filter.c | 18 ++++++++++++++++++
> 2 files changed, 19 insertions(+)
>
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index 97e1fd19ff58..d2acd5aeae8d 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -3530,6 +3530,7 @@ struct bpf_sock {
> __u32 dst_ip4;
> __u32 dst_ip6[4];
> __u32 state;
> + __u32 rx_queue_mapping;
> };
>
> struct bpf_tcp_sock {
> diff --git a/net/core/filter.c b/net/core/filter.c
> index bd2853d23b50..c4ba92204b73 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -6829,6 +6829,7 @@ bool bpf_sock_is_valid_access(int off, int size, enum bpf_access_type type,
> case offsetof(struct bpf_sock, protocol):
> case offsetof(struct bpf_sock, dst_port):
> case offsetof(struct bpf_sock, src_port):
> + case offsetof(struct bpf_sock, rx_queue_mapping):
> case bpf_ctx_range(struct bpf_sock, src_ip4):
> case bpf_ctx_range_till(struct bpf_sock, src_ip6[0], src_ip6[3]):
> case bpf_ctx_range(struct bpf_sock, dst_ip4):
> @@ -7872,6 +7873,23 @@ u32 bpf_sock_convert_ctx_access(enum bpf_access_type type,
> skc_state),
> target_size));
> break;
> + case offsetof(struct bpf_sock, rx_queue_mapping):
> +#ifdef CONFIG_XPS
> + *insn++ = BPF_LDX_MEM(
> + BPF_FIELD_SIZEOF(struct sock, sk_rx_queue_mapping),
> + si->dst_reg, si->src_reg,
> + bpf_target_off(struct sock, sk_rx_queue_mapping,
> + sizeof_field(struct sock,
> + sk_rx_queue_mapping),
> + target_size));
> + *insn++ = BPF_JMP_IMM(BPF_JNE, si->dst_reg, NO_QUEUE_MAPPING,
> + 1);
> + *insn++ = BPF_MOV64_IMM(si->dst_reg, -1);
> +#else
> + *insn++ = BPF_MOV64_IMM(si->dst_reg, 0);
This should be -1 as queue mapping as well if XPS is not configured, no?
Otherwise, how do you tell it apart from an actual mapping to 0 if XPS is
built-in?
> + *target_size = 2;
> +#endif
> + break;
> }
>
> return insn - insn_buf;
>
next prev parent reply other threads:[~2020-05-22 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 18:28 [bpf-next PATCH v2] bpf: Add rx_queue_mapping to bpf_sock Amritha Nambiar
2020-05-22 23:34 ` Daniel Borkmann [this message]
2020-05-27 0:27 ` Nambiar, Amritha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a648441b-6546-c904-d2a0-583b4c9e77d7@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=amritha.nambiar@intel.com \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).