From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8166EC433DF for ; Mon, 3 Aug 2020 23:30:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8846A2076E for ; Mon, 3 Aug 2020 23:30:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729161AbgHCXar (ORCPT ); Mon, 3 Aug 2020 19:30:47 -0400 Received: from mga09.intel.com ([134.134.136.24]:6429 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbgHCXar (ORCPT ); Mon, 3 Aug 2020 19:30:47 -0400 IronPort-SDR: rrHiTugo8CLxKJ4fthIDr/tGl3J1zakJ7cCsThZcvXjIFMdaQdPofXt9AUnGRWEILmAQqYOSMR BibehjO/PK8A== X-IronPort-AV: E=McAfee;i="6000,8403,9702"; a="153396661" X-IronPort-AV: E=Sophos;i="5.75,431,1589266800"; d="scan'208";a="153396661" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2020 16:30:47 -0700 IronPort-SDR: Bfa6Mk/3TljASKKKeoj/2SXRPL5z1Q5pu/NhxYAVQ+EFf9u7kAn3fj4UFeJMhSIGuy1gD0uluY tMdv3P0TKbuA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,431,1589266800"; d="scan'208";a="366638860" Received: from jekeller-mobl1.amr.corp.intel.com (HELO [10.212.196.183]) ([10.212.196.183]) by orsmga001.jf.intel.com with ESMTP; 03 Aug 2020 16:30:45 -0700 Subject: Re: [iproute2-next v2 5/5] devlink: support setting the overwrite mask To: David Ahern , netdev@vger.kernel.org References: <20200801002159.3300425-1-jacob.e.keller@intel.com> <20200801002159.3300425-6-jacob.e.keller@intel.com> <0bb895a2-e233-0426-3e48-d8422fa5b7cf@gmail.com> From: Jacob Keller Organization: Intel Corporation Message-ID: Date: Mon, 3 Aug 2020 16:30:42 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.0.1 MIME-Version: 1.0 In-Reply-To: <0bb895a2-e233-0426-3e48-d8422fa5b7cf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/3/2020 8:53 AM, David Ahern wrote: > On 7/31/20 6:21 PM, Jacob Keller wrote: >> Add support for specifying the overwrite sections to allow in the flash >> update command. This is done by adding a new "overwrite" option which >> can take either "settings" or "identifiers" passing the overwrite mode >> multiple times will combine the fields using bitwise-OR. >> >> Signed-off-by: Jacob Keller >> --- >> devlink/devlink.c | 37 +++++++++++++++++++++++++++++++++++-- >> 1 file changed, 35 insertions(+), 2 deletions(-) >> > > 5/5? I only see 2 - 4/5 and 5/5. Please re-send against latest > iproute2-next. > Slightly unrelated: but the recent change to using a bitfield32 results in a "GENMASK is undefined".. I'm not sure what the proper way to fix this is, since we'd like to still use GENMASK to define the supported bitfields. I guess we need to pull in more headers? Or define something in include/utils.h? Thanks, Jake