From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B559FC7618F for ; Mon, 22 Jul 2019 18:21:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C5D32190D for ; Mon, 22 Jul 2019 18:21:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n6eN2XrD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731492AbfGVSVo (ORCPT ); Mon, 22 Jul 2019 14:21:44 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:38247 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726907AbfGVSVn (ORCPT ); Mon, 22 Jul 2019 14:21:43 -0400 Received: by mail-pf1-f196.google.com with SMTP id y15so17773433pfn.5 for ; Mon, 22 Jul 2019 11:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4lLoLGx2NAdGQHIXBm/Mpz3LZx5lcu8xL5l7rMjyPd8=; b=n6eN2XrDXgSOtWns6Mg3aWw2I2iq107RAP0EkwTTUYy6afhhlEaqll4wixXI4U+icF 2otsoJiLtZ9ocQorX/HPtX1EZitzoo3EuTuaPtzE9yG8P8RLkd2yVJezjCGCd4sWrAdh PW8F0m81qBykgmtu+d+j9qpMwhBAeAB6ZBBVIJclBJZ3xbyB6PPPhEU+fLe2uSMhPBaO 2Es/NuPapWjCZqwL2SIeoI4O3CWDHDDz99RRU9RYy8Y5MoIhYJTPDWSnkImmdMjCn0Xx 5Tpnz0OMneseZvI9ShhuZYDZ5uFJVF1t3HaWCmtDmlE8ovMR8mx0txmsQGGnNHUQBXqj XF4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4lLoLGx2NAdGQHIXBm/Mpz3LZx5lcu8xL5l7rMjyPd8=; b=Bd5YwfpVkGX6k018LX706gxXDgiDYCO+JvsDk+czKYt+gdsWarGEcSlhZqO3+fWxJu wXm2QrNaLXVs/Tr9SzR4qNgT5LsZjEJkx6BkYKoYd7KHvWbPB18X1QAK06WIxWOFOMli e/VPDGCSWwBcOoKyqgekToeAsiBiFzz4oI/ZQjIKRFKtQdQcmukGiEX02AiGdevbokCo MJEX1tou0z5ClRRWPxqH/RBmIEsXsHnM9Gnm2AWa/d51Uo5ak1+Ffk1AVl+ZhN5uBhr+ gTc9wxAU6+gxZfU9uDeF6Fke+r2DYEFDxiUwhjWkICMjhfpTek2BMq55fKze3mtp+lHh n74g== X-Gm-Message-State: APjAAAUZZ0M3jiO6BgQpVM7lkE5zsACplU5eIKEEDhb7K0kzXrpBbpvB 0f4q+qop306pqAEYzZrkdmOrwaxdHNU= X-Google-Smtp-Source: APXvYqyn33vErbYZnpX9CrhGuVjdkPjbJMFfAFeQ59jviogwTACawWMnM5ftQbXzQKiFbq7l9VBBTw== X-Received: by 2002:a63:ea50:: with SMTP id l16mr73850399pgk.160.1563819703252; Mon, 22 Jul 2019 11:21:43 -0700 (PDT) Received: from [172.27.227.205] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id s11sm12201379pgc.78.2019.07.22.11.21.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jul 2019 11:21:42 -0700 (PDT) Subject: Re: [PATCH iproute2] etf: make printing of variable JSON friendly To: Vedang Patel , netdev@vger.kernel.org Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, stephen@networkplumber.org, vinicius.gomes@intel.com, leandro.maciel.dorileo@intel.com References: <1563572443-10879-1-git-send-email-vedang.patel@intel.com> From: David Ahern Message-ID: Date: Mon, 22 Jul 2019 12:21:39 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1563572443-10879-1-git-send-email-vedang.patel@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/19/19 3:40 PM, Vedang Patel wrote: > In iproute2 txtime-assist series, it was pointed out that print_bool() > should be used to print binary values. This is to make it JSON friendly. > > So, make the corresponding changes in ETF. > > Fixes: 8ccd49383cdc ("etf: Add skip_sock_check") > Reported-by: Stephen Hemminger > Signed-off-by: Vedang Patel > --- > tc/q_etf.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tc/q_etf.c b/tc/q_etf.c > index c2090589bc64..307c50eed48b 100644 > --- a/tc/q_etf.c > +++ b/tc/q_etf.c > @@ -176,12 +176,12 @@ static int etf_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) > get_clock_name(qopt->clockid)); > > print_uint(PRINT_ANY, "delta", "delta %d ", qopt->delta); > - print_string(PRINT_ANY, "offload", "offload %s ", > - (qopt->flags & TC_ETF_OFFLOAD_ON) ? "on" : "off"); > - print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s ", > - (qopt->flags & TC_ETF_DEADLINE_MODE_ON) ? "on" : "off"); > - print_string(PRINT_ANY, "skip_sock_check", "skip_sock_check %s", > - (qopt->flags & TC_ETF_SKIP_SOCK_CHECK) ? "on" : "off"); > + if (qopt->flags & TC_ETF_OFFLOAD_ON) > + print_bool(PRINT_ANY, "offload", "offload ", true); > + if (qopt->flags & TC_ETF_DEADLINE_MODE_ON) > + print_bool(PRINT_ANY, "deadline_mode", "deadline_mode ", true); > + if (qopt->flags & TC_ETF_SKIP_SOCK_CHECK) > + print_bool(PRINT_ANY, "skip_sock_check", "skip_sock_check", true); > > return 0; > } > This changes existing output for TC_ETF_OFFLOAD_ON and TC_ETF_DEADLINE_MODE_ON which were added a year ago.