From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
DENG Qingfang <dqfext@gmail.com>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>
Subject: Re: [RFC PATCH net-next 3/4] net: dsa: create a helper for locating EtherType DSA headers on RX
Date: Tue, 10 Aug 2021 02:21:41 -0700 [thread overview]
Message-ID: <a8da86b9-973c-f678-509f-c6fac2c7bbb9@gmail.com> (raw)
In-Reply-To: <20210809115722.351383-4-vladimir.oltean@nxp.com>
On 8/9/2021 4:57 AM, Vladimir Oltean wrote:
> It seems that protocol tagging driver writers are always surprised about
> the formula they use to reach their EtherType header on RX, which
> becomes apparent from the fact that there are comments in multiple
> drivers that mention the same information.
>
> Create a helper that returns a void pointer to skb->data - 2, as well as
> centralize the explanation why that is the case.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-08-10 9:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 11:57 [RFC PATCH net-next 0/4] DSA tagger helpers Vladimir Oltean
2021-08-09 11:57 ` [RFC PATCH net-next 1/4] net: dsa: create a helper that strips EtherType DSA headers on RX Vladimir Oltean
2021-08-10 1:01 ` Andrew Lunn
2021-08-10 9:18 ` Florian Fainelli
2021-08-11 13:23 ` Linus Walleij
2021-08-09 11:57 ` [RFC PATCH net-next 2/4] net: dsa: create a helper which allocates space for EtherType DSA headers Vladimir Oltean
2021-08-10 1:03 ` Andrew Lunn
2021-08-10 9:21 ` Florian Fainelli
2021-08-11 13:24 ` Linus Walleij
2021-08-09 11:57 ` [RFC PATCH net-next 3/4] net: dsa: create a helper for locating EtherType DSA headers on RX Vladimir Oltean
2021-08-10 1:05 ` Andrew Lunn
2021-08-10 9:21 ` Florian Fainelli [this message]
2021-08-11 13:27 ` Linus Walleij
2021-08-09 11:57 ` [RFC PATCH net-next 4/4] net: dsa: create a helper for locating EtherType DSA headers on TX Vladimir Oltean
2021-08-10 1:07 ` Andrew Lunn
2021-08-10 9:22 ` Florian Fainelli
2021-08-11 13:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8da86b9-973c-f678-509f-c6fac2c7bbb9@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).