From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CBB4C43613 for ; Fri, 21 Jun 2019 15:43:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEF1E20673 for ; Fri, 21 Jun 2019 15:43:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pensando.io header.i=@pensando.io header.b="PxTkgyZ6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726224AbfFUPnB (ORCPT ); Fri, 21 Jun 2019 11:43:01 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:46224 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbfFUPnA (ORCPT ); Fri, 21 Jun 2019 11:43:00 -0400 Received: by mail-pg1-f194.google.com with SMTP id v9so3542039pgr.13 for ; Fri, 21 Jun 2019 08:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=VU5fPpWVToE49ocBRa3LlHEIV7AaGbTYKFU+jFizyxI=; b=PxTkgyZ6ee+072mN2hgmI8ZgSeZCNVOLXZ5qCklBqFRXW28Gyj0Tmy2aIHWSyo5l+Q 4xpA7M99KgCVipt32bs+QKSizrsV59jnRZMvWTLTe6IOaCI5cqYEM4sOwh1VEFoz+Y+r Ruo+M3uXkSM7TCk8iFU+GniLHhYuuRF8E94R7YzV4nD6d5NZFDZZonZPOB5YnOefJfwG X43ZimyDEqQZ7a2CWnBnEjnsPNoxqmFJuEleBohYLpqHqeatWXCKDTUUAchrZB0NJUst aq0iFbMXXAWzDgJiMr5p0VZAFFAglIIZpFDjVc8Qqmo1qqOzKUy5Z6UOXHczvyliCf3f YiQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=VU5fPpWVToE49ocBRa3LlHEIV7AaGbTYKFU+jFizyxI=; b=H27B04eUN4hfe0sen3rKCvPSkbJrLA4ii234TtBhedNE7ZX7UDcFYn26cbSlBy7A54 q7LpHxYvsLyHBqUmJj245BEz4P6JJVF2DUGXLBWyRF2NIw63ykXDXEpVscbLg24R7rpl qBnxqKXlyjPzHrLJMiwxt/8H8WxNGQI9E1iN0NELkuyvPDKQMAj3xDEpuLG0W6jkJlTM uJbyW3AXh1xAYns2LWvn6H0G/a7VpXv0/alUwYcu++Iw5d3FsqjTjLoWX5E1+k6uBHUz iGLzgAAXU7Fp7Qnl5iYi9HuZpSyQjOnb0DbcETfROHERgYN32wmjY7FHRdAkRcD16B1Y +DcA== X-Gm-Message-State: APjAAAV5Hda/tWwMw5/3lEhZ1sXm+ebL9+QoG9yrzb9wlmuaNevqLR+U PRxXfi8PsRdMR2ZBUyhXYM3+UmkTUDE= X-Google-Smtp-Source: APXvYqzkWTwddXyh1UH/1BAIciQugmWT434vVsrZPPSct7B6Zu3eKmzFbDV0tRZs0GY8ryAfFtaiXA== X-Received: by 2002:a17:90a:3688:: with SMTP id t8mr7273621pjb.35.1561131780083; Fri, 21 Jun 2019 08:43:00 -0700 (PDT) Received: from Shannons-MacBook-Pro.local ([12.1.37.26]) by smtp.gmail.com with ESMTPSA id 22sm4007161pfu.179.2019.06.21.08.42.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Jun 2019 08:42:59 -0700 (PDT) Subject: Re: [PATCH] ionic: fix simple_open.cocci warnings To: kbuild test robot Cc: kbuild-all@01.org, netdev@vger.kernel.org References: <20190620202424.23215-3-snelson@pensando.io> <20190621092723.GA96768@lkp-kbuild10> From: Shannon Nelson Message-ID: Date: Fri, 21 Jun 2019 08:42:58 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190621092723.GA96768@lkp-kbuild10> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6/21/19 2:27 AM, kbuild test robot wrote: > From: kbuild test robot > > drivers/net/ethernet/pensando/ionic/ionic_debugfs.c:12:11-20: WARNING opportunity for simple_open, see also structure on line 56 > > Remove an open coded simple_open() function > and replace file operations references to the function > with simple_open() instead. > > Generated by: scripts/coccinelle/api/simple_open.cocci > > Fixes: fb4f52d18a75 ("ionic: Add hardware init and device commands") > CC: Shannon Nelson > Signed-off-by: kbuild test robot Thanks, I'll roll this into the next verison of the patchset. sln > --- > > url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/ionic-Add-basic-framework-for-IONIC-Network-device-driver/20190621-110046 > > ionic_debugfs.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c > @@ -9,12 +9,6 @@ > > #ifdef CONFIG_DEBUG_FS > > -static int blob_open(struct inode *inode, struct file *filp) > -{ > - filp->private_data = inode->i_private; > - return 0; > -} > - > static ssize_t blob_read(struct file *filp, char __user *buffer, > size_t count, loff_t *ppos) > { > @@ -53,7 +47,7 @@ static ssize_t blob_write(struct file *f > > static const struct file_operations blob_fops = { > .owner = THIS_MODULE, > - .open = blob_open, > + .open = simple_open, > .read = blob_read, > .write = blob_write, > };