* [PATCH net] net: dsa: mv88e6xxx: Fix serdes irq setup going recursive
@ 2019-01-27 21:48 Andrew Lunn
2019-01-28 7:20 ` David Miller
2019-01-28 8:37 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Lunn @ 2019-01-27 21:48 UTC (permalink / raw)
To: David Miller; +Cc: Vivien Didelot, netdev, Andrew Lunn
Duec to a typo, mv88e6390_serdes_irq_setup() calls itself, rather than
mv88e6390x_serdes_irq_setup(). It then blows the stack, and shortly
after the machine blows up.
Fixes: 2defda1f4b91 ("net: dsa: mv88e6xxx: Add support for SERDES on ports 2-8 for 6390X")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/serdes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c
index 2caa8c8b4b55..1bfc5ff8d81d 100644
--- a/drivers/net/dsa/mv88e6xxx/serdes.c
+++ b/drivers/net/dsa/mv88e6xxx/serdes.c
@@ -664,7 +664,7 @@ int mv88e6390_serdes_irq_setup(struct mv88e6xxx_chip *chip, int port)
if (port < 9)
return 0;
- return mv88e6390_serdes_irq_setup(chip, port);
+ return mv88e6390x_serdes_irq_setup(chip, port);
}
void mv88e6390x_serdes_irq_free(struct mv88e6xxx_chip *chip, int port)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dsa: mv88e6xxx: Fix serdes irq setup going recursive
2019-01-27 21:48 [PATCH net] net: dsa: mv88e6xxx: Fix serdes irq setup going recursive Andrew Lunn
@ 2019-01-28 7:20 ` David Miller
2019-01-28 8:37 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-01-28 7:20 UTC (permalink / raw)
To: andrew; +Cc: vivien.didelot, netdev
From: Andrew Lunn <andrew@lunn.ch>
Date: Sun, 27 Jan 2019 22:48:00 +0100
> Duec to a typo, mv88e6390_serdes_irq_setup() calls itself, rather than
> mv88e6390x_serdes_irq_setup(). It then blows the stack, and shortly
> after the machine blows up.
>
> Fixes: 2defda1f4b91 ("net: dsa: mv88e6xxx: Add support for SERDES on ports 2-8 for 6390X")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks Andrew.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dsa: mv88e6xxx: Fix serdes irq setup going recursive
2019-01-27 21:48 [PATCH net] net: dsa: mv88e6xxx: Fix serdes irq setup going recursive Andrew Lunn
2019-01-28 7:20 ` David Miller
@ 2019-01-28 8:37 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2019-01-28 8:37 UTC (permalink / raw)
To: Andrew Lunn, David Miller; +Cc: Vivien Didelot, netdev
Hello!
On 28.01.2019 0:48, Andrew Lunn wrote:
> Duec to a typo, mv88e6390_serdes_irq_setup() calls itself, rather than
Due?
> mv88e6390x_serdes_irq_setup(). It then blows the stack, and shortly
> after the machine blows up.
Never seen a stack overflow in the kernel... :-)
> Fixes: 2defda1f4b91 ("net: dsa: mv88e6xxx: Add support for SERDES on ports 2-8 for 6390X")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-28 8:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-27 21:48 [PATCH net] net: dsa: mv88e6xxx: Fix serdes irq setup going recursive Andrew Lunn
2019-01-28 7:20 ` David Miller
2019-01-28 8:37 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).