From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BCADC433E0 for ; Wed, 29 Jul 2020 23:59:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7FAC2072A for ; Wed, 29 Jul 2020 23:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728147AbgG2X7u (ORCPT ); Wed, 29 Jul 2020 19:59:50 -0400 Received: from mga11.intel.com ([192.55.52.93]:52930 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727840AbgG2X7u (ORCPT ); Wed, 29 Jul 2020 19:59:50 -0400 IronPort-SDR: aCygtU7H57cr8DKXFikcb8vewY3RNXb7GsMSvQP8L8PPldUCKHFcTvbqwgElZC6P6qSGH8yBEM qLsJuJk0WiSQ== X-IronPort-AV: E=McAfee;i="6000,8403,9697"; a="149351961" X-IronPort-AV: E=Sophos;i="5.75,412,1589266800"; d="scan'208";a="149351961" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2020 16:59:49 -0700 IronPort-SDR: nHQhp1G2jHjFJ6RKOjJdrqRfcLV4g4qvz5XepqyYbBnIiqN2hjD9g/nBFYzyooPNwfxnfMb8q+ iZMnVWJ4X4Eg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,412,1589266800"; d="scan'208";a="304385635" Received: from jekeller-mobl1.amr.corp.intel.com (HELO [10.212.162.155]) ([10.212.162.155]) by orsmga002.jf.intel.com with ESMTP; 29 Jul 2020 16:59:48 -0700 Subject: Re: [RFC PATCH net-next v2 6/6] devlink: add overwrite mode to flash update To: Jakub Kicinski Cc: Jiri Pirko , "netdev@vger.kernel.org" , Tom Herbert , Jiri Pirko , Jonathan Corbet , Michael Chan , Bin Luo , Saeed Mahameed , Leon Romanovsky , Ido Schimmel , Danielle Ratson References: <20200717183541.797878-1-jacob.e.keller@intel.com> <20200717183541.797878-7-jacob.e.keller@intel.com> <20200720100953.GB2235@nanopsycho> <20200720085159.57479106@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200721135356.GB2205@nanopsycho> <20200721100406.67c17ce9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200722105139.GA3154@nanopsycho> <02874ECE860811409154E81DA85FBB58C8AF3382@fmsmsx101.amr.corp.intel.com> <20200722095228.2f2c61b8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200729161603.1aeeb5cb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Jacob Keller Organization: Intel Corporation Message-ID: Date: Wed, 29 Jul 2020 16:59:48 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.0.1 MIME-Version: 1.0 In-Reply-To: <20200729161603.1aeeb5cb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/29/2020 4:16 PM, Jakub Kicinski wrote: > On Wed, 29 Jul 2020 15:49:05 -0700 Jacob Keller wrote: >> The security revision is tied into the management firmware image and >> would always be updated when an image is updated, but the minimum >> revision is only updated on an explicit request request. > > Does it have to be updated during FW flashing? Can't it be a devlink > param? > Oh, right. I'd forgotten about that type of parameter. Makes sense. I'll implement the current security revision as a component of flash info (so that it can be reported via devlink info, and can't be changed) but the minimum should be able to be a parameter just fine. Thanks, Jake