From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5E29C6FA86 for ; Thu, 15 Sep 2022 06:25:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229591AbiIOGZV (ORCPT ); Thu, 15 Sep 2022 02:25:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiIOGZU (ORCPT ); Thu, 15 Sep 2022 02:25:20 -0400 Received: from sender4-op-o14.zoho.com (sender4-op-o14.zoho.com [136.143.188.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAA767677C; Wed, 14 Sep 2022 23:25:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663223085; cv=none; d=zohomail.com; s=zohoarc; b=QhT+tIPCFvVSGigO6Bnk6e6Bh2/EWYUf/infZjmQGj6iO1TGNFp9mXguDuOUm/DpWvf1OgKkKfqzIb7ZN6l9ctq0lWG5/c7d1CSAjTq9cvsm/EE5alr2+5SNHKUxhuVbtlW8IBJ9ao1FlLD5+bECDV2zoGW0ERjC6wFnGpVteZ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663223085; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=SaIR9ac/WNESLZgIJ7NfWDPlOEsbmM5EMrQeBc4rRcQ=; b=GuqatCqi3aNs0LWmQ5GNwlHSYYwAWDsF+H0n4REekizZUb117F/XuatyMC2g/jcD0YiW3vzn3hJN0FaaKwBPpjtMyOueJBdmUDuH34d8RrIXUsWSeagJIFN/B5GVfqb3tgRyCWelbulAdkRevrMZE3eXoEl767I/gNWhoQyVQ4Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=arinc9.com; spf=pass smtp.mailfrom=arinc.unal@arinc9.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1663223085; s=zmail; d=arinc9.com; i=arinc.unal@arinc9.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=SaIR9ac/WNESLZgIJ7NfWDPlOEsbmM5EMrQeBc4rRcQ=; b=XDIDPnVMmzMdjdr4PWLtYOkpEuSco+I7L4NEGf6+WLphaJt9VGVtFjp9BCrmtJuU 7ij/J6uM1EF/jrYfl1rkVfuPnaeTFjQfXrlAeYxX/MKVqAxa1Ngir6nbwhzyqohMOwn 1gQDBTSmHpK+ZKrFbJ0+d3Q77xQtFQSvBjt7EQxw= Received: from [10.10.10.3] (37.120.152.236 [37.120.152.236]) by mx.zohomail.com with SMTPS id 1663223084388940.7928349747789; Wed, 14 Sep 2022 23:24:44 -0700 (PDT) Message-ID: Date: Thu, 15 Sep 2022 09:24:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 04/10] dt-bindings: memory: mt7621: add syscon as compatible string Content-Language: en-US To: Sergio Paracuellos Cc: Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thomas Bogendoerfer , Greg Kroah-Hartman , Sean Wang , Landen Chao , DENG Qingfang , erkin.bozoglu@xeront.com, netdev , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel@lists.infradead.org, "moderated list:ARM/Mediatek SoC support" , linux-kernel , "open list:MIPS" References: <20220914085451.11723-1-arinc.unal@arinc9.com> <20220914085451.11723-5-arinc.unal@arinc9.com> <20220914151414.GA2233841-robh@kernel.org> <44045164-692d-c8f5-3216-b043fb821634@arinc9.com> From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 15.09.2022 06:21, Sergio Paracuellos wrote: > On Wed, Sep 14, 2022 at 5:19 PM Arınç ÜNAL wrote: >> >> On 14.09.2022 18:14, Rob Herring wrote: >>> On Wed, Sep 14, 2022 at 11:54:45AM +0300, Arınç ÜNAL wrote: >>>> Add syscon as a constant string on the compatible property as it's required >>>> for the SoC to work. Update the example accordingly. >>> >>> It's not required. It's required to automagically create a regmap. That >>> can be done yourself as well. The downside to adding 'syscon' is it >>> requires a DT update. Maybe that's fine for this platform? I don't know. >> >> My GB-PC2 won't boot without syscon on mt7621.dtsi. This string was >> always there on the memory controller node on mt7621.dtsi. > > The string was introduced because the mt7621 clock driver needs to > read some registers creating a regmap from the syscon. The bindings > were added before the clock driver was properly mainlined and at first > the clock driver was using ralink architecture dependent operations > rt_memc_* defined in > 'arch/mips/include/asm/mach-ralink/ralink_regs.h'. I forgot to update > the mem controller binding when memc became a syscon so I think this > patch is correct. I also think the sample should use 'syscon' in the > node name instead of memory-controller. Will change to syscon in v2. Arınç