From: Felix Fietkau <nbd@nbd.name>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC v2] net/core: add optional threading for rps backlog processing
Date: Fri, 17 Feb 2023 13:35:06 +0100 [thread overview]
Message-ID: <acaf1607-412d-3142-1465-8d8439520228@nbd.name> (raw)
In-Reply-To: <CANn89iJXjEWJcFbSMwKOXuupCVr4b-y4Gh+LwOQg+TQwJPQ=eg@mail.gmail.com>
On 17.02.23 13:23, Eric Dumazet wrote:
> On Fri, Feb 17, 2023 at 11:06 AM Felix Fietkau <nbd@nbd.name> wrote:
>>
>> When dealing with few flows or an imbalance on CPU utilization, static RPS
>> CPU assignment can be too inflexible. Add support for enabling threaded NAPI
>> for RPS backlog processing in order to allow the scheduler to better balance
>> processing. This helps better spread the load across idle CPUs.
>>
>> Signed-off-by: Felix Fietkau <nbd@nbd.name>
>> ---
>>
>> RFC v2:
>> - fix rebase error in rps locking
>
> Why only deal with RPS ?
>
> It seems you propose the sofnet_data backlog be processed by a thread,
> instead than from softirq ?
Right. I originally wanted to mainly improve RPS, but my patch does
cover backlog in general. I will update the description in the next
version. Does the approach in general make sense to you?
Thanks,
- Felix
next prev parent reply other threads:[~2023-02-17 12:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 10:06 [RFC v2] net/core: add optional threading for rps backlog processing Felix Fietkau
2023-02-17 12:23 ` Eric Dumazet
2023-02-17 12:35 ` Felix Fietkau [this message]
2023-02-17 12:57 ` Eric Dumazet
2023-02-17 13:40 ` Felix Fietkau
2023-02-17 14:38 ` Eric Dumazet
2023-02-17 15:26 ` Felix Fietkau
2023-02-17 15:54 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acaf1607-412d-3142-1465-8d8439520228@nbd.name \
--to=nbd@nbd.name \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).