From: David Ahern <dsahern@gmail.com>
To: Stephen Suryaputra <ssuryaextr@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net v2] ipv4: reset rt_iif for recirculated mcast/bcast out pkts
Date: Wed, 26 Jun 2019 11:28:40 -0600 [thread overview]
Message-ID: <ad55a4f7-aa10-0e23-f8c8-da4c10c41710@gmail.com> (raw)
In-Reply-To: <20190626062116.4319-1-ssuryaextr@gmail.com>
On 6/26/19 12:21 AM, Stephen Suryaputra wrote:
> Multicast or broadcast egress packets have rt_iif set to the oif. These
> packets might be recirculated back as input and lookup to the raw
> sockets may fail because they are bound to the incoming interface
> (skb_iif). If rt_iif is not zero, during the lookup, inet_iif() function
> returns rt_iif instead of skb_iif. Hence, the lookup fails.
>
> v2: Make it non vrf specific (David Ahern). Reword the changelog to
> reflect it.
> Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com>
> ---
> include/net/route.h | 1 +
> net/ipv4/ip_output.c | 12 ++++++++++++
> net/ipv4/route.c | 33 +++++++++++++++++++++++++++++++++
> 3 files changed, 46 insertions(+)
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2019-06-26 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 6:21 [PATCH net v2] ipv4: reset rt_iif for recirculated mcast/bcast out pkts Stephen Suryaputra
2019-06-26 17:28 ` David Ahern [this message]
2019-06-26 19:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad55a4f7-aa10-0e23-f8c8-da4c10c41710@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ssuryaextr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).