From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2FB2C43381 for ; Mon, 18 Feb 2019 17:06:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E9CE217D9 for ; Mon, 18 Feb 2019 17:06:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="RoSUQj80" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390941AbfBRRGC (ORCPT ); Mon, 18 Feb 2019 12:06:02 -0500 Received: from smtprelay2.synopsys.com ([198.182.60.111]:54102 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388046AbfBRRGC (ORCPT ); Mon, 18 Feb 2019 12:06:02 -0500 Received: from mailhost.synopsys.com (badc-mailhost2.synopsys.com [10.192.0.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtprelay.synopsys.com (Postfix) with ESMTPS id 1353910C1029; Mon, 18 Feb 2019 09:06:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1550509562; bh=kcZZRim/dDY5VsaQSUqm/M/3X+SgTQwpjqTpw8X6gnU=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=RoSUQj80se/m4dZQTZoBmTeauJ3LSEiejF9qcW6tMdyRK2N2raiNWlCR7DCMUdWTq fEJyGQ9OPhuiO8vacB/HwjIGuYQpn5LE377kEyytOJHI+oRwJ0Yb1vdI4ITYzerCDp u5jV7Nbi4WltFWteOO+ci8dlFX/x4Gsduxv4GUS+tqtmmPS00SfnsOedNlVrJYz/Cx d6eiuje9eWrYqeOfkBagT+CHwy6oEqJmeH9fizBtXAqBol3eIXZR+UYSeT5TzOHsk5 IpGyonYJpOdaP2dzAALw52PgVZSUehzd1ERDpqSHl3vPNVcf0cjV+O8IvrkUi2nwz7 vsTpGqNvmwGYA== Received: from US01WEHTC3.internal.synopsys.com (us01wehtc3.internal.synopsys.com [10.15.84.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id 63861A005A; Mon, 18 Feb 2019 17:06:01 +0000 (UTC) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by US01WEHTC3.internal.synopsys.com (10.15.84.232) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Feb 2019 09:06:01 -0800 Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by DE02WEHTCB.internal.synopsys.com (10.225.19.94) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Feb 2019 18:05:59 +0100 Received: from [10.107.19.176] (10.107.19.176) by DE02WEHTCA.internal.synopsys.com (10.225.19.80) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Feb 2019 18:05:58 +0100 Subject: Re: stmmac / meson8b-dwmac To: Simon Huelck , Jose Abreu , Martin Blumenstingl CC: Emiliano Ingrassia , , , , References: <20190206103645.GA2482@ingrassia.epigenesys.com> <3001f244-8904-1e89-9595-62a65a7b32ae@gmx.de> <330a523a-c1d6-4a99-3287-459096af0330@synopsys.com> <2abbf79a-cdff-b6a7-42de-79ea2c6ab367@synopsys.com> <7afdaa0d-d0ef-b223-1f6e-2b52bfa44784@gmx.de> <6f25da2b-7f28-b888-3240-7178ac75c90c@synopsys.com> <84fb981c-75ab-ef9e-edd6-cd0c52d9dc36@synopsys.com> <8bae9cd6-5c44-30e3-bfe5-8d6f853f170e@synopsys.com> <065407cd-c13b-e74c-7798-508650c12caf@gmx.de> <227be4e9-b0cc-a011-2558-71a17567246f@synopsys.com> <45e73e8c-a0fb-6f8f-8dc6-3aa2103fdda3@gmx.de> <4493b245-de93-46cd-327b-8091a3babc3a@gmx.de> From: Jose Abreu Message-ID: Date: Mon, 18 Feb 2019 17:05:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <4493b245-de93-46cd-327b-8091a3babc3a@gmx.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.176] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/18/2019 4:51 PM, Simon Huelck wrote: > Hi, > > no im testing vanilla mainline kernel and against 4.14. where > performance was ok. but turning off EEE via ethtool should have same > results than removal of that patch. > > But, since it was mainlined recently , not long ago, i think this was > tested ?? The thing is that phy_init_eee() is called by stmmac and this function does not take into account the broken modes if it's called too early which will cause driver to enable LPI in MAC. And anyway, if you have lpi values in the ethtool stats then EEE is being enabled by stmmac. Please try the change I suggested. Thanks, Jose Miguel Abreu