From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DF5AC433E0 for ; Mon, 11 Jan 2021 22:09:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EC5322D00 for ; Mon, 11 Jan 2021 22:09:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389313AbhAKWJN (ORCPT ); Mon, 11 Jan 2021 17:09:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:52768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730835AbhAKWJM (ORCPT ); Mon, 11 Jan 2021 17:09:12 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5EAC422CBE; Mon, 11 Jan 2021 22:08:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610402912; bh=4p3GlMa5uuzaUQpucb08pxfSVG1/RhEJjBvTXywbceg=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=MAFzJWUGNc7vfusWtiOs2a9vtCpqjlILFwU3lxeRNkV0I7EeqoE1zR8F4zAhmerGZ BpUL9jvs6WMrmq2rOCCnJOkPA9XjlsjtMztuf5h5e1dOcqws0gwtx3wTLG8QXAIkg/ pTLRqW7okfTbpwvN2o6F0ywd0YIn1MGiR3d4dUUXDhMZv62RoGDpuePfP9fZ5EWTk2 71OvW46TZFsimqes/Rr+scDabd4BHkIDlnuep/tie8d27ArIqgXP9hjXaWsrgs58WR sOJp/PabduZWc7V2TvA0Me0rudQdRE9gdPaZ/3bFt2A9getq2cXE/0yaACUvRE9E7v qlv0jZ7AyR9Vw== Message-ID: Subject: Re: [PATCH v6 net-next 07/15] net: remove return value from dev_get_stats From: Saeed Mahameed To: Vladimir Oltean , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Cong Wang , Stephen Hemminger , Eric Dumazet , George McCollister , Oleksij Rempel , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , Arnd Bergmann , Taehee Yoo , Jiri Pirko , Florian Westphal , Nikolay Aleksandrov , Pravin B Shelar , Sridhar Samudrala Date: Mon, 11 Jan 2021 14:08:29 -0800 In-Reply-To: <20210109172624.2028156-8-olteanv@gmail.com> References: <20210109172624.2028156-1-olteanv@gmail.com> <20210109172624.2028156-8-olteanv@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 2021-01-09 at 19:26 +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > After commit 28172739f0a2 ("net: fix 64 bit counters on 32 bit > arches"), > dev_get_stats got an additional argument for storage of statistics. > At > this point, dev_get_stats could return either the passed "storage" > argument, or the output of .ndo_get_stats64. > > Then commit caf586e5f23c ("net: add a core netdev->rx_dropped > counter") > came, and the output of .ndo_get_stats64 (still returning a pointer > to > struct rtnl_link_stats64) started being ignored. > > Then came commit bc1f44709cf2 ("net: make ndo_get_stats64 a void > function") which made .ndo_get_stats64 stop returning anything. > > So now, dev_get_stats always reports the "storage" pointer received > as > argument. This is useless. Some drivers are dealing with unnecessary > complexity due to this, using another pointer to poke around the > returned statistics, when they can do that directly through the > stack-allocated struct rtnl_link_stats64. > > Refactor these callers to ignore the return value completely and just > access the values from their struct rtnl_link_stats64 local variable. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Saeed Mahameed