From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
netdev@vger.kernel.org
Subject: [PATCH] caif: Use UTILITY_NAME_LENGTH instead of hard-coding 16
Date: Sat, 16 Mar 2024 11:16:10 +0100 [thread overview]
Message-ID: <af10f5a3236d47fd183487c9dcba3b3b3c66b595.1710584144.git.christophe.jaillet@wanadoo.fr> (raw)
UTILITY_NAME_LENGTH is 16. So better use the former when defining the
'utility_name' array. This makes the intent clearer when it is used around
line 260.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
net/caif/cfctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/caif/cfctrl.c b/net/caif/cfctrl.c
index 8480684f2762..b6d9462f92b9 100644
--- a/net/caif/cfctrl.c
+++ b/net/caif/cfctrl.c
@@ -206,7 +206,7 @@ int cfctrl_linkup_request(struct cflayer *layer,
u8 tmp8;
struct cfctrl_request_info *req;
int ret;
- char utility_name[16];
+ char utility_name[UTILITY_NAME_LENGTH];
struct cfpkt *pkt;
struct cflayer *dn = cfctrl->serv.layer.dn;
--
2.44.0
next reply other threads:[~2024-03-16 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-16 10:16 Christophe JAILLET [this message]
2024-03-18 3:21 ` [PATCH] caif: Use UTILITY_NAME_LENGTH instead of hard-coding 16 Ratheesh Kannoth
2024-03-18 8:05 ` Dan Carpenter
2024-03-18 21:47 ` Christophe JAILLET
2024-03-18 9:25 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af10f5a3236d47fd183487c9dcba3b3b3c66b595.1710584144.git.christophe.jaillet@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).