From: Alexander H Duyck <alexander.duyck@gmail.com>
To: Gerhard Engleder <gerhard@engleder-embedded.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net-next v4 02/10] tsnep: Forward NAPI budget to napi_consume_skb()
Date: Tue, 10 Jan 2023 07:50:53 -0800 [thread overview]
Message-ID: <afcd8835dc2239084f873c74fcaf997047ab319f.camel@gmail.com> (raw)
In-Reply-To: <20230109191523.12070-3-gerhard@engleder-embedded.com>
On Mon, 2023-01-09 at 20:15 +0100, Gerhard Engleder wrote:
> NAPI budget must be forwarded to napi_consume_skb(). It is used to
> detect non-NAPI context.
>
> Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com>
> ---
> drivers/net/ethernet/engleder/tsnep_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c
> index 7cc5e2407809..d148ba422b8c 100644
> --- a/drivers/net/ethernet/engleder/tsnep_main.c
> +++ b/drivers/net/ethernet/engleder/tsnep_main.c
> @@ -550,7 +550,7 @@ static bool tsnep_tx_poll(struct tsnep_tx *tx, int napi_budget)
> skb_tstamp_tx(entry->skb, &hwtstamps);
> }
>
> - napi_consume_skb(entry->skb, budget);
> + napi_consume_skb(entry->skb, napi_budget);
> entry->skb = NULL;
>
> tx->read = (tx->read + count) % TSNEP_RING_SIZE;
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
next prev parent reply other threads:[~2023-01-10 15:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 19:15 [PATCH net-next v4 00/10] tsnep: XDP support Gerhard Engleder
2023-01-09 19:15 ` [PATCH net-next v4 01/10] tsnep: Use spin_lock_bh for TX Gerhard Engleder
2023-01-10 15:49 ` Alexander H Duyck
2023-01-10 19:44 ` Gerhard Engleder
2023-01-09 19:15 ` [PATCH net-next v4 02/10] tsnep: Forward NAPI budget to napi_consume_skb() Gerhard Engleder
2023-01-10 15:50 ` Alexander H Duyck [this message]
2023-01-09 19:15 ` [PATCH net-next v4 03/10] tsnep: Do not print DMA mapping error Gerhard Engleder
2023-01-10 15:53 ` Alexander H Duyck
2023-01-10 19:47 ` Gerhard Engleder
2023-01-09 19:15 ` [PATCH net-next v4 04/10] tsnep: Add adapter down state Gerhard Engleder
2023-01-10 16:05 ` Alexander H Duyck
2023-01-10 20:16 ` Gerhard Engleder
2023-01-09 19:15 ` [PATCH net-next v4 05/10] tsnep: Add XDP TX support Gerhard Engleder
2023-01-10 16:56 ` Alexander H Duyck
2023-01-10 21:07 ` Gerhard Engleder
2023-01-10 22:38 ` Alexander Duyck
2023-01-11 18:51 ` Gerhard Engleder
2023-01-09 19:15 ` [PATCH net-next v4 06/10] tsnep: Substract TSNEP_RX_INLINE_METADATA_SIZE once Gerhard Engleder
2023-01-10 17:05 ` Alexander H Duyck
2023-01-09 19:15 ` [PATCH net-next v4 07/10] tsnep: Prepare RX buffer for XDP support Gerhard Engleder
2023-01-09 19:15 ` [PATCH net-next v4 08/10] tsnep: Add RX queue info " Gerhard Engleder
2023-01-10 17:29 ` Alexander H Duyck
2023-01-10 21:21 ` Gerhard Engleder
2023-01-10 22:27 ` Alexander Duyck
2023-01-09 19:15 ` [PATCH net-next v4 09/10] tsnep: Add XDP RX support Gerhard Engleder
2023-01-10 17:40 ` Alexander H Duyck
2023-01-10 21:28 ` Gerhard Engleder
2023-01-10 22:30 ` Alexander Duyck
2023-01-09 19:15 ` [PATCH net-next v4 10/10] tsnep: Support XDP BPF program setup Gerhard Engleder
2023-01-10 17:33 ` Alexander H Duyck
2023-01-10 21:38 ` Gerhard Engleder
2023-01-10 23:00 ` Alexander H Duyck
2023-01-11 18:58 ` Gerhard Engleder
2023-01-11 0:12 ` Jakub Kicinski
2023-01-11 19:11 ` Gerhard Engleder
2023-01-11 20:06 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afcd8835dc2239084f873c74fcaf997047ab319f.camel@gmail.com \
--to=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gerhard@engleder-embedded.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).