From: Julia Lawall <julia.lawall@lip6.fr>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: ebiederm@xmission.com, rshearma@brocade.com, davem@davemloft.net,
netdev@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, kbuild-all@01.org
Subject: Re: [PATCH net-next] mpls: support for dead routes
Date: Tue, 3 Nov 2015 08:11:11 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1511030810310.2043@localhost6.localdomain6> (raw)
In-Reply-To: <201511030632.M6iNpQTU%fengguang.wu@intel.com>
Please check on what was intended.
julia
On Tue, 3 Nov 2015, kbuild test robot wrote:
> CC: kbuild-all@01.org
> In-Reply-To: <1446498529-50275-1-git-send-email-roopa@cumulusnetworks.com>
> TO: Roopa Prabhu <roopa@cumulusnetworks.com>
> CC: ebiederm@xmission.com, rshearma@brocade.com, davem@davemloft.net, netdev@vger.kernel.org
> CC: davem@davemloft.net, netdev@vger.kernel.org
>
> Hi Roopa,
>
> [auto build test WARNING on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
>
> url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/mpls-support-for-dead-routes/20151103-051211
> :::::: branch date: 88 minutes ago
> :::::: commit date: 88 minutes ago
>
> >> net/mpls/af_mpls.c:702:6-22: duplicated argument to && or ||
>
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout 21fa92d07a7254a2042ded6647fc4b91332c6d0e
> vim +702 net/mpls/af_mpls.c
>
> f8efb73c Roopa Prabhu 2015-10-23 686 int nhs = 0;
> f8efb73c Roopa Prabhu 2015-10-23 687 int err = 0;
> f8efb73c Roopa Prabhu 2015-10-23 688
> f8efb73c Roopa Prabhu 2015-10-23 689 change_nexthops(rt) {
> f8efb73c Roopa Prabhu 2015-10-23 690 int attrlen;
> f8efb73c Roopa Prabhu 2015-10-23 691
> f8efb73c Roopa Prabhu 2015-10-23 692 nla_via = NULL;
> f8efb73c Roopa Prabhu 2015-10-23 693 nla_newdst = NULL;
> f8efb73c Roopa Prabhu 2015-10-23 694
> f8efb73c Roopa Prabhu 2015-10-23 695 err = -EINVAL;
> f8efb73c Roopa Prabhu 2015-10-23 696 if (!rtnh_ok(rtnh, remaining))
> f8efb73c Roopa Prabhu 2015-10-23 697 goto errout;
> f8efb73c Roopa Prabhu 2015-10-23 698
> 1c78efa8 Robert Shearman 2015-10-23 699 /* neither weighted multipath nor any flags
> 1c78efa8 Robert Shearman 2015-10-23 700 * are supported
> 1c78efa8 Robert Shearman 2015-10-23 701 */
> 21fa92d0 Roopa Prabhu 2015-11-02 @702 if (rtnh->rtnh_flags || rtnh->rtnh_flags)
> 1c78efa8 Robert Shearman 2015-10-23 703 goto errout;
> 1c78efa8 Robert Shearman 2015-10-23 704
> f8efb73c Roopa Prabhu 2015-10-23 705 attrlen = rtnh_attrlen(rtnh);
> f8efb73c Roopa Prabhu 2015-10-23 706 if (attrlen > 0) {
> f8efb73c Roopa Prabhu 2015-10-23 707 struct nlattr *attrs = rtnh_attrs(rtnh);
> f8efb73c Roopa Prabhu 2015-10-23 708
> f8efb73c Roopa Prabhu 2015-10-23 709 nla_via = nla_find(attrs, attrlen, RTA_VIA);
> f8efb73c Roopa Prabhu 2015-10-23 710 nla_newdst = nla_find(attrs, attrlen, RTA_NEWDST);
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
next parent reply other threads:[~2015-11-03 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201511030632.M6iNpQTU%fengguang.wu@intel.com>
2015-11-03 7:11 ` Julia Lawall [this message]
2015-11-03 14:56 ` [PATCH net-next] mpls: support for dead routes roopa
2015-11-02 21:08 Roopa Prabhu
2015-11-03 4:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1511030810310.2043@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=rshearma@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).