From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF3B7C06511 for ; Tue, 2 Jul 2019 16:15:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F450206A3 for ; Tue, 2 Jul 2019 16:15:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbfGBQPq (ORCPT ); Tue, 2 Jul 2019 12:15:46 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:45774 "EHLO xavier.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726404AbfGBQPq (ORCPT ); Tue, 2 Jul 2019 12:15:46 -0400 Received: from ramsan ([84.194.98.4]) by xavier.telenet-ops.be with bizsmtp id XsFi2000t05gfCL01sFiK5; Tue, 02 Jul 2019 18:15:44 +0200 Received: from geert (helo=localhost) by ramsan with local-esmtp (Exim 4.90_1) (envelope-from ) id 1hiLRW-0003TW-LY; Tue, 02 Jul 2019 18:15:42 +0200 Date: Tue, 2 Jul 2019 18:15:42 +0200 (CEST) From: Geert Uytterhoeven To: Saeed Mahameed , Tal Gilboa cc: "David S. Miller" , Doug Ledford , Jason Gunthorpe , Leon Romanovsky , Or Gerlitz , Sagi Grimberg , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , linux-kernel@vger.kernel.org Subject: Re: [for-next V2 06/10] linux/dim: Move implementation to .c files In-Reply-To: <20190625205701.17849-7-saeedm@mellanox.com> Message-ID: References: <20190625205701.17849-1-saeedm@mellanox.com> <20190625205701.17849-7-saeedm@mellanox.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Saeed, Tal, On Tue, 25 Jun 2019, Saeed Mahameed wrote: > From: Tal Gilboa > > Moved all logic from dim.h and net_dim.h to dim.c and net_dim.c. > This is both more structurally appealing and would allow to only > expose externally used functions. > > Signed-off-by: Tal Gilboa > Signed-off-by: Saeed Mahameed This is now commit 4f75da3666c0c572 ("linux/dim: Move implementation to .c files") in net-next. > --- a/drivers/net/ethernet/broadcom/Kconfig > +++ b/drivers/net/ethernet/broadcom/Kconfig > @@ -8,6 +8,7 @@ config NET_VENDOR_BROADCOM > default y > depends on (SSB_POSSIBLE && HAS_DMA) || PCI || BCM63XX || \ > SIBYTE_SB1xxx_SOC > + select DIMLIB Merely enabling a NET_VENDOR_* symbol should not enable inclusion of any additional code, cfr. the help text for the NET_VENDOR_BROADCOM option. Hence please move the select to the config symbol(s) for the driver(s) that need it. > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -562,6 +562,14 @@ config SIGNATURE > Digital signature verification. Currently only RSA is supported. > Implementation is done using GnuPG MPI library > > +config DIMLIB > + bool "DIM library" > + default y Please drop this line, as optional library code should never be included by default. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds