From: Paul Walmsley <paul.walmsley@sifive.com>
To: Yash Shah <yash.shah@sifive.com>
Cc: Andreas Schwab <schwab@suse.de>,
davem@davemloft.net, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, robh+dt@kernel.org,
mark.rutland@arm.com, nicolas.ferre@microchip.com,
palmer@sifive.com, aou@eecs.berkeley.edu, ynezz@true.cz,
sachin.ghadi@sifive.com
Subject: Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000
Date: Mon, 17 Jun 2019 02:58:20 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1906170252410.19994@viisi.sifive.com> (raw)
In-Reply-To: <mvmtvco62k9.fsf@suse.de>
Hi Yash,
On Mon, 17 Jun 2019, Andreas Schwab wrote:
> On Jun 17 2019, Yash Shah <yash.shah@sifive.com> wrote:
>
> > - Add "MACB_SIFIVE_FU540" in Kconfig to support SiFive FU540 in macb
> > driver. This is needed because on FU540, the macb driver depends on
> > SiFive GPIO driver.
>
> This of course requires that the GPIO driver is upstreamed first.
What's the impact of enabling CONFIG_MACB_SIFIVE_FU540 when the GPIO
driver isn't present? (After modifying the Kconfig "depends" line
appropriately.)
Looks to me that it shouldn't have an impact unless the DT string is
present, and even then, the impact might simply be that the MACB driver
may not work?
- Paul
next prev parent reply other threads:[~2019-06-17 9:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 4:19 [PATCH v2 0/2] Add macb support for SiFive FU540-C000 Yash Shah
2019-06-17 4:19 ` [PATCH v2 1/2] macb: bindings doc: add sifive fu540-c000 binding Yash Shah
2019-06-17 8:56 ` Paul Walmsley
2019-06-17 4:19 ` [PATCH v2 2/2] macb: Add support for SiFive FU540-C000 Yash Shah
2019-06-17 15:58 ` Andrew Lunn
2019-06-18 4:04 ` Yash Shah
2019-06-17 4:43 ` [PATCH v2 0/2] Add macb " Yash Shah
2019-06-17 8:25 ` Andreas Schwab
2019-06-17 9:58 ` Paul Walmsley [this message]
2019-06-17 10:01 ` Andreas Schwab
2019-06-17 10:05 ` Paul Walmsley
2019-06-17 10:14 ` Andreas Schwab
2019-06-17 11:34 ` Paul Walmsley
2019-06-17 14:14 ` Troy Benjegerdes
2019-06-17 14:20 ` Paul Walmsley
2019-06-17 18:42 ` Alistair Francis
2019-06-18 3:26 ` Paul Walmsley
2019-06-18 9:32 ` Anup Patel
2019-06-18 16:49 ` Troy Benjegerdes
2019-06-18 23:40 ` Atish Patra
2019-06-18 23:11 ` Alistair Francis
2019-06-17 10:22 ` Yash Shah
2019-06-17 10:28 ` Paul Walmsley
2019-06-17 11:15 ` Yash Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1906170252410.19994@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=palmer@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=schwab@suse.de \
--cc=yash.shah@sifive.com \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).