From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C7EDC31E59 for ; Mon, 17 Jun 2019 10:28:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11DAF2084D for ; Mon, 17 Jun 2019 10:28:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="I1Xjncqz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728279AbfFQK2G (ORCPT ); Mon, 17 Jun 2019 06:28:06 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:42518 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728248AbfFQK2F (ORCPT ); Mon, 17 Jun 2019 06:28:05 -0400 Received: by mail-ed1-f65.google.com with SMTP id z25so15391531edq.9 for ; Mon, 17 Jun 2019 03:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=8UBAA4hob1aUdMG3Ki6/LwA/eBo66cYa0fDftPuC+I0=; b=I1XjncqzU2jmO6RevBy9IzFleq0nMlnkC6MDumuIsz5JVeH2+1xm/ZhpM/VGcEN+9K 9pSyXGeLCIhrXK1FMrm37s22+ShjPNYMS8/Wx1HJfbo39srKyIqMMMhR0mqjHq0Eqj2/ EEIYhEhsAbI7rnU22Ey0TKxrY8eexf9LGgSGqqGzvkvb6TeYsTMqmkFl0qWa7ckNmYhC gRbkiSnv1F7ZON4E588pZS0q2mwTvOSENtx+10LxFski6vF+C1ehb6SXdQghnOXmCoNC IgdbbbhFi0YtJmlL+kXM01BwLelRvL7Itusxmc9seVJAYzA6dGsXWWWqK+8gqLxSqbUc O3rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=8UBAA4hob1aUdMG3Ki6/LwA/eBo66cYa0fDftPuC+I0=; b=CiLa8fdYs+ChefcuFXavZ5PxMlkWt9zCQxAGTYT3aODLKoZ7LANxZ3aV6pttW4P7u/ iFMEsV2PrYpdgCGPrEofneF+34RWzGIE6USy6z2RzTR+O4C3lkgMAZOcjC5QYCbCnoJ+ O6KC4Z0l74WxJzPZe/6/A7rfS9VCcxkXs7vkBJcor6bdMDvbS6aq02lcsEa9ILRl38AT oSQ+bqctApUX2E+jNVgLhpMDPUtnmr09PRkxQYqBotgR6G2UzkIxqHXA1XHMD7L5mOaU soBA/zdj1LsBCi/tmGg5WmKE1Z3HvKCYmc5I3AcRTBpJBzQSYmMA1451rDm6oNjrt7G+ cqYQ== X-Gm-Message-State: APjAAAXkn8w2NUlq1b/GBuH1jAuKcbNvIANVde+LgcfTQNBPgrkjYUqn ozK+bQKLNx0nu8EWpXWlD2iwSQ== X-Google-Smtp-Source: APXvYqwMwtN/9BiCAeDSq8bw6UaVIvcm2zKgRR7fZSgp8cG8nJGZNjfgqqkTyxFwZd/sIBVKqa0hXQ== X-Received: by 2002:a17:906:a39a:: with SMTP id k26mr69719766ejz.82.1560767284087; Mon, 17 Jun 2019 03:28:04 -0700 (PDT) Received: from localhost ([81.92.102.43]) by smtp.gmail.com with ESMTPSA id f24sm3624644edf.30.2019.06.17.03.28.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 17 Jun 2019 03:28:03 -0700 (PDT) Date: Mon, 17 Jun 2019 03:28:02 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Yash Shah cc: Andreas Schwab , David Miller , devicetree@vger.kernel.org, netdev , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Rob Herring , Mark Rutland , Nicolas Ferre , Palmer Dabbelt , Albert Ou , =?ISO-8859-15?Q?Petr_=A6tetiar?= , Sachin Ghadi , sagar.kadam@sifive.com Subject: Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000 In-Reply-To: Message-ID: References: <1560745167-9866-1-git-send-email-yash.shah@sifive.com> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 17 Jun 2019, Yash Shah wrote: > On Mon, Jun 17, 2019 at 3:28 PM Paul Walmsley wrote: > > > On Mon, 17 Jun 2019, Andreas Schwab wrote: > > > > > On Jun 17 2019, Yash Shah wrote: > > > > > > > - Add "MACB_SIFIVE_FU540" in Kconfig to support SiFive FU540 in macb > > > > driver. This is needed because on FU540, the macb driver depends on > > > > SiFive GPIO driver. > > > > > > This of course requires that the GPIO driver is upstreamed first. > > > > What's the impact of enabling CONFIG_MACB_SIFIVE_FU540 when the GPIO > > driver isn't present? (After modifying the Kconfig "depends" line > > appropriately.) > > > > Looks to me that it shouldn't have an impact unless the DT string is > > present, and even then, the impact might simply be that the MACB driver > > may not work? > > Yes, there won't be an impact other than MACB driver not working. OK. In that case, there doesn't seem much point to adding the Kconfig option. Could you please post a new version without it? > In any case, without GPIO driver, PHY won't get reset and the network > interface won't come up. Naturally, in the medium term, we want Linux to handle the reset. But if there's no GPIO driver present, and the bootloader handles the PHY reset before the kernel starts, would the network driver work in that case? - Paul